Fix "Avoid CamelCase" checkpatch.pl check for type definitions
DVICTRL_SETPOWER and DVICTRL_HOTPLUGDETECTION in ddk750_dvi.h.
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_dvi.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk75
On Tue, Apr 06, 2021 at 11:36:41AM +0200, Greg KH wrote:
> On Tue, Apr 06, 2021 at 02:18:41AM -0700, Pavle Rohalj wrote:
> > - struct dvi_ctrl_device *pCurrentDviCtrl;
> > + struct dvi_ctrl_device *p_current_dvi_ctrl;
>
> Does this change make sense? Why keep the "p_" here? We do not need or
On Tue, Apr 06, 2021 at 02:18:41AM -0700, Pavle Rohalj wrote:
> - struct dvi_ctrl_device *pCurrentDviCtrl;
> + struct dvi_ctrl_device *p_current_dvi_ctrl;
Does this change make sense? Why keep the "p_" here? We do not need or
use, this type of variable naming in the kernel.
Also, please
Fix "Avoid CamelCase" checkpatch.pl checks for 106 camel case
instances:
Signed-off-by: Pavle Rohalj
---
drivers/staging/sm750fb/ddk750_dvi.c| 32 ++---
drivers/staging/sm750fb/ddk750_dvi.h| 64 +-
drivers/staging/sm750fb/ddk750_mode.c | 88 +++---
drive
On Mon 2020-07-20 14:05:47, Dan Murphy wrote:
> Fix the camel case of MultiColor to Multicolor.
>
> Fixes: f5a6eb5c5e38 ("leds: multicolor: Introduce a multicolor class
> definition")
> Signed-off-by: Dan Murphy
Thanks, applied.
Fix the camel case of MultiColor to Multicolor.
Fixes: f5a6eb5c5e38 ("leds: multicolor: Introduce a multicolor class
definition")
Signed-off-by: Dan Murphy
---
Documentation/leds/leds-class-multicolor.rst | 2 +-
drivers/leds/Kconfig | 2 +-
2 files
On 6/22/2020 3:11 PM, Joe Perches wrote:
> On Mon, 2020-06-22 at 14:58 -0700, Jacob Keller wrote:
>> When seeding the camel case file, checkpatch.pl uses the $root directory
>> in order to find the acceptable list of allowed camel case words.
>>
>> However, if the
On Mon, 2020-06-22 at 14:58 -0700, Jacob Keller wrote:
> When seeding the camel case file, checkpatch.pl uses the $root directory
> in order to find the acceptable list of allowed camel case words.
>
> However, if the current directory is a git repository, checkpatch.pl
> attempt
When seeding the camel case file, checkpatch.pl uses the $root directory
in order to find the acceptable list of allowed camel case words.
However, if the current directory is a git repository, checkpatch.pl
attempts to seed using the local git directory.
This is problematic if checkpatch.pl is
On Mon, Mar 04, 2019 at 12:55:32AM +0800, Yifeng Li wrote:
> Rename the function setDisplayControl() to set_display_control().
> This fixes the following checkpatch.pl warning:
>
> CHECK: Avoid CamelCase:
>
> Suggested-by: Jin Chen
> Signed-off-by: Jin Chen
> [to...@tomli.me: resent as tri
checkpatch.pl avoids warning about camel case of some definitions by
seeding a file that tracks all of the currently committed camel case
definitions.
To build this seed file, checkpatch.pl decides between using git or the
--root parameter.
This works as long as you don't run checkpatch.pl
On Mon, Mar 04, 2019 at 12:55:32AM +0800, Yifeng Li wrote:
> Rename the function setDisplayControl() to set_display_control().
> This fixes the following checkpatch.pl warning:
>
> CHECK: Avoid CamelCase:
>
> Suggested-by: Jin Chen
> Signed-off-by: Jin Chen
> [to...@tomli.me: resent as tri
Rename the function setDisplayControl() to set_display_control().
This fixes the following checkpatch.pl warning:
CHECK: Avoid CamelCase:
Suggested-by: Jin Chen
Signed-off-by: Jin Chen
[to...@tomli.me: resent as trivial patch, reworded the commit message]
Signed-off-by: Yifeng Li
---
dri
On Sat, Dec 29, 2018 at 11:59:52PM +0100, Petr Sedlák wrote:
> Replace variable uDelayUnit with u_delay_unit. Issue found by
> checkpatch.
>
> Signed-off-by: Petr Sedlák
> ---
> drivers/staging/vt6655/upc.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers
On Sat, 2018-12-29 at 23:59 +0100, Petr Sedlák wrote:
> Replace variable uDelayUnit with u_delay_unit. Issue found by
> checkpatch.
probably better as a static inline too.
> diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h
[]
> @@ -42,15 +42,15 @@
> #define VNSvOutPortD(d
Replace variable uDelayUnit with u_delay_unit. Issue found by
checkpatch.
Signed-off-by: Petr Sedlák
---
drivers/staging/vt6655/upc.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h
index 61b3e568ff9a..384af2
On Fri, Jul 13, 2018 at 11:39:38AM +0200, Greg KH wrote:
> On Wed, Jul 11, 2018 at 08:21:43PM +0100, John Whitmore wrote:
> > Simple rename of the preprosessor switch, protecting against multiple
> > inclusion of the header file. Change to clear the checkpatch coding style
> > issue.
> >
> > Signe
Simple rename of the preprosessor switch, protecting against multiple
inclusion of the header file. Change to clear the checkpatch coding style
issue.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driver
On Wed, Jul 11, 2018 at 08:21:43PM +0100, John Whitmore wrote:
> Simple rename of the preprosessor switch, protecting against multiple
> inclusion of the header file. Change to clear the checkpatch coding style
> issue.
>
> Signed-off-by: John Whitmore
> ---
> drivers/staging/rtl8192u/r8192U.h |
Simple rename of the preprosessor switch, protecting against multiple
inclusion of the header file. Change to clear the checkpatch coding style
issue.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driver
Change camel-case names to snake-case names; to avoid variable name
conflicts, rename table index variables to idx_*.
Signed-off-by: Quytelda Kahja
---
.../staging/rtl8723bs/hal/hal_com_phycfg.c| 200 +-
1 file changed, 105 insertions(+), 95 deletions(-)
diff --git a
Replace camel-case member names with snake-case names per the linux
kernel coding style guidelines.
Signed-off-by: Quytelda Kahja
---
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 14
.../staging/rtl8723bs/include/rtl8723b_hal.h | 32 +--
2 files changed, 23
Change the parameter of the macro to the snake case 'fw_hdr' instead
of '_pFwHdr'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h
b/driver
Change the members of 'struct rt_firmware' to be snake case instead
of camel-case, per the kernel coding style guide.
Signed-off-by: Quytelda Kahja
---
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c| 16
drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 4 ++-
Linux kernel coding style dictates the use of snake case for variable
naming.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 32 +-
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_
On Thu, Feb 22, 2018 at 05:32:59PM -0800, Quytelda Kahja wrote:
> Changed a variable name from camel to snake case to fix a coding style
> issue.
>
> Signed-off-by: Quytelda Kahja
> ---
> drivers/staging/gdm724x/hci_packet.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
Changed a variable name from camel to snake case to fix a coding style
issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/staging/gdm724x/hci_packet.h
in
On Wed, Feb 21, 2018 at 01:45:58PM +0300, Dan Carpenter wrote:
> On Wed, Feb 21, 2018 at 02:39:28AM -0800, Quytelda Kahja wrote:
> > Changed a variable name from camel to snake case to fix a coding style
> > issue.
> >
> > Signed-off-by: Quytelda Kahja
> > ---
> > drivers/staging/gdm724x/hci_pac
On Wed, Feb 21, 2018 at 03:15:54AM -0800, Quytelda Kahja wrote:
> That could be the case, though I'm not sure where to find any specs.
> Though looking through the history of this driver, it seems that some
> of the variable names have been slowly changing from camel case t
That could be the case, though I'm not sure where to find any specs.
Though looking through the history of this driver, it seems that some
of the variable names have been slowly changing from camel case to
snake case.
Thanks,
Quytelda Kahja
On Wed, Feb 21, 2018 at 2:45 AM, Dan Carpenter
On Wed, Feb 21, 2018 at 02:39:28AM -0800, Quytelda Kahja wrote:
> Changed a variable name from camel to snake case to fix a coding style
> issue.
>
> Signed-off-by: Quytelda Kahja
> ---
> drivers/staging/gdm724x/hci_packet.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
Changed a variable name from camel to snake case to fix a coding style
issue.
Signed-off-by: Quytelda Kahja
---
drivers/staging/gdm724x/hci_packet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/hci_packet.h
b/drivers/staging/gdm724x/hci_packet.h
in
Remove Camel casing by renaming variables.
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.c | 4 ++--
drivers/staging/pi433/pi433_if.h | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
Hi,
This series pf patches solves some of the coding style
issues. I have corrected long lines, changed comment style,
renamed enums and variables that were in camel case.
Tried to get zero erros and warnings on the pi433_if.h file.
Regards,
Rishabh Hardas
Rishabh Hardas (4):
staging: pi433
Hi,
This series pf patches solves some of the coding style
issues. I have corrected long lines, changed comment style,
renamed enums and variables that were in camel case.
Tried to get zero erros and warnings on the pi433_if.h file.
Regards,
Rishabh Hardas
Rishabh Hardas (4):
staging: pi433
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.c | 4 ++--
drivers/staging/pi433/pi433_if.h | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index ed737f4..11c042b 100644
--- a/drivers/
Remove Camel Case warning found using checkpatch.pl
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging/rtl8188eu/core/rtw_ap.c
index 647a922d79d1..6c63a9bbb876 100644
--- a
On Sat, Jan 07, 2017 at 03:48:05PM +0530, sumit negi wrote:
> Fixed a camel style issue.
Really? Look at what you changed:
> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const stru
Fixed a camel style issue.
Signed-off-by: sumit negi
---
drivers/staging/comedi/comedidev.h | 6 +++---
drivers/staging/comedi/drivers/dt2815.c | 2 +-
drivers/staging/comedi/drivers/ni_670x.c | 2 +-
drivers/staging/comedi/drivers/pcl726.c | 8
4 files changed, 9 insertions(+),
On 25/12/16 19:56, Scott Matheina wrote:
> Cases of camel case were fixed by making variables lower case throughout
> the file.
>
> Signed-off-by: Scott Matheina
So of these cases might arguably be worth doing, but extreme care is needed to
ensure
that the code is not broken.
A
Hi Scott,
[auto build test ERROR on iio/togreg]
[also build test ERROR on v4.9 next-20161224]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Scott-Matheina/Checkpatch-fixes-to-driver-staging-iio
Cases of camel case were fixed by making variables lower case throughout
the file.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 82 ++---
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316
Cases of camel case were fixed by making variables lower case throughout
the file.
Signed-off-by: Scott Matheina
---
drivers/staging/iio/addac/adt7316.c | 82 ++---
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316
On Friday, June 17, 2016 9:02 PM, Greg KH wrote:
>> The patch looks fine (although this odd-ball Comedi driver shouldn't really
>> be sending signals to a user-space task!).
>
> Yeah, that's really odd, fixing that would be nice...
This is the last addi-data driver that does this. It's on my list
On Wed, Jun 01, 2016 at 10:35:57AM +0100, Ian Abbott wrote:
> On 01/06/16 10:19, Ashwin Ravichandran wrote:
> > Fixed a coding style issue.
> >
> > Signed-off-by: Ashwin Ravichandran
> > ---
> > drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
> > drivers/staging/comedi/driver
On Wed, Jun 01, 2016 at 02:19:35AM -0700, Ashwin Ravichandran wrote:
> Fixed a coding style issue.
Which one?
And where are the 2648 previous patches in this series?
thanks,
greg k-h
Fix "Avoid camel case" issue thrown by checkpatch.pl
Signed-off-by: Rithvik Patibandla
---
drivers/staging/vt6656/card.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index a3fa6d8..53b469c 10
On 01/06/16 10:19, Ashwin Ravichandran wrote:
Fixed a coding style issue.
Signed-off-by: Ashwin Ravichandran
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletion
Fixed a coding style issue.
Signed-off-by: Ashwin Ravichandran
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/a
On Tue, May 31, 2016 at 11:00:01PM -0700, Ashwin wrote:
> From: Ashwin R
I need a "full" name here, and in the signed-off-by line please.
thanks,
greg k-h
From: Ashwin R
Fixed a coding style issue.
Signed-off-by: Ashwin R
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/dri
On 29/05/16 14:31, Jaime Arrocha wrote:
> From: Jaime Arrocha
>
> Fixed several checks about camel case use provided by checkpatch.pl.
> CHECK: Avoid CamelCase
> Changes verified to work by compiling module.
>
> Signed-off-by: Jaime Arrocha
Purpose of the patch is good
From: Jaime Arrocha
Fixed several checks about camel case use provided by checkpatch.pl.
CHECK: Avoid CamelCase
Changes verified to work by compiling module.
Signed-off-by: Jaime Arrocha
---
drivers/staging/slicoss/slic.h| 30 +++
drivers/staging/slicoss/slicoss.c | 50
Is camel case discouraged in linux code? I noticed a check for it in
checkpatch.pl but it is not one of the default options form scanning.
Jeff
On 2/20/16, Jeff Merkey wrote:
> Is camel case discouraged in linux code? I noticed a check for it in
> checkpatch.pl but it is not one of the default options form scanning.
>
> Jeff
>
Found a great writeup from Greg on the subject. question answered.
Do not use it if possib
For the functions LNetInit and LNetFini move away from
camel case to lnet_init and lnet_fini.
Signed-off-by: James Simmons
---
drivers/staging/lustre/include/linux/lnet/api.h|3 ---
.../staging/lustre/include/linux/lnet/lib-lnet.h |3 +++
.../staging/lustre/include/linux/lnet/lib
For the functions LNetInit and LNetFini move away from
camel case to lnet_init and lnet_fini.
Signed-off-by: James Simmons
---
drivers/staging/lustre/include/linux/lnet/api.h|3 ---
.../staging/lustre/include/linux/lnet/lib-lnet.h |3 +++
.../staging/lustre/include/linux/lnet/lib
From: Fabian Frederick
Date: Tue, 4 Nov 2014 20:52:14 +0100
> use standard uppercase for definitions
>
> Signed-off-by: Fabian Frederick
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
use standard uppercase for definitions
Signed-off-by: Fabian Frederick
---
net/ipv4/igmp.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index fb70e3e..3f80513 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.
From: Giedrius Statkevičius
Convert labels from Camel Case to lower case, remove unnecessary
parantheses around operands of dereference operators and remove unneeded
empty lines before }.
Gets rid of a checkpatch.pl "check" that code should avoid Camel Case,
also the code had a bu
From: Giedrius Statkevičius
Convert labels from Camel Case to lower case, remove unnecessary parantheses
around operands of dereference operators and remove unneeded empty lines before
}.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/rts5208/rtsx_chip.c | 52
Fixes the following checkpatch.pl issue:
CHECK: Avoid CamelCase:
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72
On Tue, Apr 22, 2014 at 11:22:59PM +0200, Fabio Falzoi wrote:
> @@ -316,7 +316,7 @@ static int rts51x_control_thread(void *__chip)
> if (chip->srb->result != DID_ABORT << 16)
> chip->srb->scsi_done(chip->srb);
> else
> -SkipForAbort :
> +abort :
Ju
Replace camel case labels with linux coding style compliant names.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5139/rts51x.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c
index
Replace camel case labels with linux coding style compliant names.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5139/rts51x.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c
index
On Wed, Mar 13, 2013 at 12:19:20PM -0400, Jacob Garber wrote:
> This is a patch to usbdux.c that fixes the camel case warnings found
> by the checkpatch.pl tool
>
> Signed-off-by: Jacob Garber
> ---
> -static int usbduxsub_submit_InURBs(struct usbduxsub *usbdux
This is a patch to usbdux.c that fixes the camel case warnings found
by the checkpatch.pl tool
Signed-off-by: Jacob Garber
---
drivers/staging/comedi/drivers/usbdux.c | 404 +++
1 file changed, 202 insertions(+), 202 deletions(-)
diff --git a/drivers/staging/comedi
Checkpatch now highlights some camel case flag names. Fix these issues.
Also fix some remaining lines > 80chars issues for completeness.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 50 ---
1 file changed, 26 insertions(+), 24 deleti
On Fri, Jan 18, 2013 at 09:56:44PM -0500, Jake Champlin wrote:
> Fixed a camel case coding style issue.
>
Stop. It's not OK to break the build.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body o
On Fri, Jan 18, 2013 at 09:56:44PM -0500, Jake Champlin wrote:
> Fixed a camel case coding style issue.
>
> Signed-off-by: Jake Champlin
> ---
> drivers/staging/zcache/zcache-main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drive
Fixed a camel case coding style issue.
Signed-off-by: Jake Champlin
---
drivers/staging/zcache/zcache-main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/zcache/zcache-main.c
b/drivers/staging/zcache/zcache-main.c
index 52b43b7..95be348 100644
--- a
On Thu, Jan 17, 2013 at 10:49:36PM -0500, Jake Champlin wrote:
> Fixed camel case style issue.
>
> Signed-off-by: Jake Champlin
> ---
> drivers/staging/comedi/drivers/addi_apci_035.c | 34
> +-
> 1 file changed, 17 insertions(+), 17 deletions(-)
D
On Thu, Jan 17, 2013 at 10:49:36PM -0500, Jake Champlin wrote:
> Fixed camel case style issue.
>
No. That doesn't work at all.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kern
Fixed camel case style issue.
Signed-off-by: Jake Champlin
---
drivers/staging/comedi/drivers/addi_apci_035.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_035.c
b/drivers/staging/comedi/drivers
Acked-by: Andy King
Signed-off-by: Dmitry Torokhov
---
drivers/misc/vmw_vmci/vmci_queue_pair.c |8
drivers/misc/vmw_vmci/vmci_queue_pair.h |2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c
b/drivers/misc/vmw_vmci/vmci_
75 matches
Mail list logo
