Re: BUG_ON drivers/char/random.c:986

2014-07-16 Thread Theodore Ts'o
On Tue, Jul 15, 2014 at 10:29:10PM +0200, Hannes Frederic Sowa wrote: > > Looks like an overflow introduced by e33ba5fa7afce1a ("random: fix nasty > entropy accounting bug"). Ted, what do you think about the following > fix? Ah, right. We're only capping ibytes to be no more entropy in the pool

Re: BUG_ON drivers/char/random.c:986

2014-07-15 Thread Hannes Frederic Sowa
On Di, 2014-07-15 at 00:36 -0400, Dave Jones wrote: > On Fri, May 16, 2014 at 10:18:40PM -0400, Theodore Ts'o wrote: > > On Fri, May 16, 2014 at 05:46:22PM -0700, Hannes Frederic Sowa wrote: > > > This should do the trick: > > > dd if=/dev/urandom of=/dev/zero bs=67108707 > > > > > > I suspec

Re: BUG_ON drivers/char/random.c:986

2014-07-14 Thread Dave Jones
On Fri, May 16, 2014 at 10:18:40PM -0400, Theodore Ts'o wrote: > On Fri, May 16, 2014 at 05:46:22PM -0700, Hannes Frederic Sowa wrote: > > This should do the trick: > > dd if=/dev/urandom of=/dev/zero bs=67108707 > > > > I suspect ee1de406ba6eb1 ("random: simplify accounting logic") as the >

Re: BUG_ON drivers/char/random.c:986 (Was: perf: use after free in perf_remove_from_context)

2014-05-17 Thread Peter Zijlstra
On Sat, May 17, 2014 at 12:24:32PM -0400, Sasha Levin wrote: > On 05/16/2014 10:18 PM, Theodore Ts'o wrote: > > On Fri, May 16, 2014 at 05:46:22PM -0700, Hannes Frederic Sowa wrote: > >> > This should do the trick: > >> > dd if=/dev/urandom of=/dev/zero bs=67108707 > >> > > >> > I suspect ee1de406

Re: BUG_ON drivers/char/random.c:986 (Was: perf: use after free in perf_remove_from_context)

2014-05-17 Thread Sasha Levin
On 05/16/2014 10:18 PM, Theodore Ts'o wrote: > On Fri, May 16, 2014 at 05:46:22PM -0700, Hannes Frederic Sowa wrote: >> > This should do the trick: >> > dd if=/dev/urandom of=/dev/zero bs=67108707 >> > >> > I suspect ee1de406ba6eb1 ("random: simplify accounting logic") as the >> > culprit. > Yep,

Re: BUG_ON drivers/char/random.c:986 (Was: perf: use after free in perf_remove_from_context)

2014-05-16 Thread Theodore Ts'o
On Fri, May 16, 2014 at 05:46:22PM -0700, Hannes Frederic Sowa wrote: > This should do the trick: > dd if=/dev/urandom of=/dev/zero bs=67108707 > > I suspect ee1de406ba6eb1 ("random: simplify accounting logic") as the > culprit. Yep, that it's it. Thanks for noticing this so quickly! I'll push

Re: BUG_ON drivers/char/random.c:986 (Was: perf: use after free in perf_remove_from_context)

2014-05-16 Thread Hannes Frederic Sowa
On Fri, May 16, 2014, at 9:21, Peter Zijlstra wrote: > On Fri, May 16, 2014 at 09:06:13AM -0700, H. Peter Anvin wrote: > > On 05/16/2014 08:34 AM, Peter Zijlstra wrote: > > > > > > While fuzzing to reproduce my issue I hit the below, its triggered loads > > > of times and then the machine wedged (

Re: BUG_ON drivers/char/random.c:986 (Was: perf: use after free in perf_remove_from_context)

2014-05-16 Thread Peter Zijlstra
On Fri, May 16, 2014 at 09:06:13AM -0700, H. Peter Anvin wrote: > On 05/16/2014 08:34 AM, Peter Zijlstra wrote: > > > > While fuzzing to reproduce my issue I hit the below, its triggered loads > > of times and then the machine wedged (needed a power cycle), I can > > provide the full console log i

Re: BUG_ON drivers/char/random.c:986 (Was: perf: use after free in perf_remove_from_context)

2014-05-16 Thread H. Peter Anvin
On 05/16/2014 08:34 AM, Peter Zijlstra wrote: > > While fuzzing to reproduce my issue I hit the below, its triggered loads > of times and then the machine wedged (needed a power cycle), I can > provide the full console log if people care. > > Anybody seen that one before? > I certainly haven't.

BUG_ON drivers/char/random.c:986 (Was: perf: use after free in perf_remove_from_context)

2014-05-16 Thread Peter Zijlstra
While fuzzing to reproduce my issue I hit the below, its triggered loads of times and then the machine wedged (needed a power cycle), I can provide the full console log if people care. Anybody seen that one before? --- [ 861.777414] [ cut here ] [ 861.777416] kernel BUG