Re: [patch] module: potential deadlock in error path

2013-01-21 Thread Dan Carpenter
Rusty, you have this right? I like Linus's version. Could you give me a Reported-by tag? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

Re: [patch] module: potential deadlock in error path

2013-01-20 Thread Linus Torvalds
On Sun, Jan 20, 2013 at 7:52 PM, Rusty Russell wrote: > > You've now conflated two completely different lock paths into a single > unlock. We have that elsewhere too. And it's what we used to have before too. So the simple fact is that commit 1fb9341ac348 just introduced this bug, and moving the

Re: [patch] module: potential deadlock in error path

2013-01-20 Thread Rusty Russell
Linus Torvalds writes: > On Sun, Jan 20, 2013 at 5:20 PM, Rusty Russell wrote: >> Dan Carpenter writes: >>> We take the lock twice if we hit this goto. >>> >>> Signed-off-by: Dan Carpenter >> >> Damn, just pushed that to Linus: should have read mail first. >> >> I've added this, thanks. > > I'

Re: [patch] module: potential deadlock in error path

2013-01-20 Thread Linus Torvalds
On Sun, Jan 20, 2013 at 5:20 PM, Rusty Russell wrote: > Dan Carpenter writes: >> We take the lock twice if we hit this goto. >> >> Signed-off-by: Dan Carpenter > > Damn, just pushed that to Linus: should have read mail first. > > I've added this, thanks. I'm not pulling this. It seems stupid.

Re: [patch] module: potential deadlock in error path

2013-01-20 Thread Rusty Russell
Dan Carpenter writes: > We take the lock twice if we hit this goto. > > Signed-off-by: Dan Carpenter Damn, just pushed that to Linus: should have read mail first. I've added this, thanks. The following changes since commit a7f2a366f62319dfebf8d4dfe8b211f631c78457: ima: fallback to MODULE_SI

[patch] module: potential deadlock in error path

2013-01-17 Thread Dan Carpenter
We take the lock twice if we hit this goto. Signed-off-by: Dan Carpenter diff --git a/kernel/module.c b/kernel/module.c index d25e359..2eefa7d 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -3239,8 +3239,10 @@ again: mutex_lock(&module_mutex); /* Find duplicate symbols (mu