We take the lock twice if we hit this goto.

Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

diff --git a/kernel/module.c b/kernel/module.c
index d25e359..2eefa7d 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3239,8 +3239,10 @@ again:
        mutex_lock(&module_mutex);
        /* Find duplicate symbols (must be called under lock). */
        err = verify_export_symbols(mod);
-       if (err < 0)
+       if (err < 0) {
+               mutex_unlock(&module_mutex);
                goto ddebug_cleanup;
+       }
 
        /* This relies on module_mutex for list integrity. */
        module_bug_finalize(info->hdr, info->sechdrs, mod);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to