Re: [kvm-devel] [PATCH 3/3] KVM: Expose MSRs to userspace

2006-11-17 Thread Christoph Hellwig
On Thu, Nov 16, 2006 at 09:17:18PM +0200, Avi Kivity wrote: > Heh. That was the original implementation by Uri. I felt that was > wrong because _IOW() encodes the size in the ioctl number, bit the > actual size is different. That really shouldn't be a problem. After all the pointer approach d

Re: [kvm-devel] [PATCH 3/3] KVM: Expose MSRs to userspace

2006-11-16 Thread Avi Kivity
Arnd Bergmann wrote: On Thursday 16 November 2006 19:04, Avi Kivity wrote: +struct kvm_msr_entry { + __u32 index; + __u32 reserved; + __u64 data; +}; + +/* for KVM_GET_MSRS and KVM_SET_MSRS */ +struct kvm_msrs { + __u32 vcpu; + __u32 nmsrs; /* number of msrs in e

Re: [kvm-devel] [PATCH 3/3] KVM: Expose MSRs to userspace

2006-11-16 Thread Arnd Bergmann
On Thursday 16 November 2006 19:04, Avi Kivity wrote: > +struct kvm_msr_entry { > +   __u32 index; > +   __u32 reserved; > +   __u64 data; > +}; > + > +/* for KVM_GET_MSRS and KVM_SET_MSRS */ > +struct kvm_msrs { > +   __u32 vcpu; > +   __u32 nmsrs; /* number of msrs in entries