Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework

2013-07-03 Thread Bo Shen
Hi Lars, On 7/3/2013 16:08, Lars-Peter Clausen wrote: On 07/03/2013 09:57 AM, Bo Shen wrote: Hi Lars, On 7/3/2013 15:36, Lars-Peter Clausen wrote: +slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR; [...] +slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR

Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework

2013-07-03 Thread Lars-Peter Clausen
On 07/03/2013 09:57 AM, Bo Shen wrote: > Hi Lars, > > On 7/3/2013 15:36, Lars-Peter Clausen wrote: > +slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR; >>[...] > >>>+slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR; >> >>Change the type

Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework

2013-07-03 Thread Bo Shen
Hi Lars, On 7/3/2013 15:36, Lars-Peter Clausen wrote: +slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR; >>[...] >>>+slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR; >> >>Change the type of phybase to dma_addr_t > >It should be: >slave_config->dst_addr

Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework

2013-07-03 Thread Lars-Peter Clausen
On 07/03/2013 03:33 AM, Bo Shen wrote: > Hi Lars-Peter, > > On 7/2/2013 23:34, Lars-Peter Clausen wrote: >> On 07/02/2013 11:04 AM, Bo Shen wrote: >> [...] >>> -/*--*\ >>> - * DMAENGINE operations >>> -\*--

Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework

2013-07-02 Thread Bo Shen
Hi Lars-Peter, On 7/2/2013 23:34, Lars-Peter Clausen wrote: On 07/02/2013 11:04 AM, Bo Shen wrote: [...] -/*--*\ - * DMAENGINE operations -\*--*/ -stat

Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework

2013-07-02 Thread Lars-Peter Clausen
On 07/02/2013 11:04 AM, Bo Shen wrote: [...] > -/*--*\ > - * DMAENGINE operations > -\*--*/ > -static bool filter(struct dma_chan *chan, void *slave) > -{