On 07/02/2013 11:04 AM, Bo Shen wrote:
[...]
> -/*--------------------------------------------------------------------------*\
> - * DMAENGINE operations
> -\*--------------------------------------------------------------------------*/
> -static bool filter(struct dma_chan *chan, void *slave)
> -{
> - struct at_dma_slave *sl = slave;
> -
> - if (sl->dma_dev == chan->device->dev) {
> - chan->private = sl;
> - return true;
> - } else {
> - return false;
> - }
> -}
I'm wondering why is filtering no longer required?
[...]
> + slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR;
[...]
> + slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR;
Change the type of phybase to dma_addr_t
[...]
> }
>
> -static int atmel_pcm_dma_prepare(struct snd_pcm_substream *substream)
> -{
> - struct snd_soc_pcm_runtime *rtd = substream->private_data;
> - struct atmel_pcm_dma_params *prtd;
> -
> - prtd = snd_soc_dai_get_dma_data(rtd->cpu_dai, substream);
> -
> - ssc_writex(prtd->ssc->regs, SSC_IER, prtd->mask->ssc_error);
> - ssc_writex(prtd->ssc->regs, SSC_CR, prtd->mask->ssc_enable);
These writes are also completely lost
> -
> - return 0;
> -}
I think it would also be good to get rid of any references to the ssc struct
from the DMA driver and move them over to the DAI driver.
- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
