Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap

2015-10-12 Thread Mark Brown
On Mon, Oct 12, 2015 at 12:48:58PM +0200, Markus Pargmann wrote: > On Fri, Oct 09, 2015 at 03:51:22PM +0800, yalin wang wrote: > > + /* if set, only the cache is modified not the HW */ > > + bool cache_only; > > + /* if set, only the HW is modified not the cache */ > > + bool cache_bypass;

Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap

2015-10-12 Thread Markus Pargmann
Hi, On Fri, Oct 09, 2015 at 03:51:22PM +0800, yalin wang wrote: > This patch change some bool variables in struct regmap { } > to be u8 v : 1 type, so that we can shrink the sizeof of struct regmap. > > Signed-off-by: yalin wang > --- > drivers/base/regmap/internal.h | 39 +++--

Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap

2015-10-09 Thread yalin wang
hi i have sync this branch, but see my patch have been merged :) seems correct. Thanks > On Oct 9, 2015, at 19:35, Mark Brown wrote: > > On Fri, Oct 09, 2015 at 03:51:22PM +0800, yalin wang wrote: >> This patch change some bool variables in struct regmap { } >> to be u8 v : 1 type, so that we

Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap

2015-10-09 Thread Mark Brown
On Fri, Oct 09, 2015 at 03:51:22PM +0800, yalin wang wrote: > This patch change some bool variables in struct regmap { } > to be u8 v : 1 type, so that we can shrink the sizeof of struct regmap. This still doesn't apply against current code - I'm looking for something that applies at least agains

[RFC V3] regmap: change bool to 1 bit variable in struct regmap

2015-10-09 Thread yalin wang
This patch change some bool variables in struct regmap { } to be u8 v : 1 type, so that we can shrink the sizeof of struct regmap. Signed-off-by: yalin wang --- drivers/base/regmap/internal.h | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) diff -