Re: [RFC PATCH] smpboot: Check for successfull allocation of cpumask vars

2014-12-09 Thread Thomas Gleixner
On Tue, 9 Dec 2014, Pranith Kumar wrote: > On Tue, Dec 9, 2014 at 3:10 PM, Thomas Gleixner wrote: > > On Tue, 9 Dec 2014, Pranith Kumar wrote: > >> zalloc_cpumask_var() can return 0 on allocation failure when > >> CONFIG_CPUMASK_OFFSTACK is set. Check for the return value and WARN() on > >> failu

Re: [RFC PATCH] smpboot: Check for successfull allocation of cpumask vars

2014-12-09 Thread Pranith Kumar
On Tue, Dec 9, 2014 at 3:10 PM, Thomas Gleixner wrote: > On Tue, 9 Dec 2014, Pranith Kumar wrote: >> zalloc_cpumask_var() can return 0 on allocation failure when >> CONFIG_CPUMASK_OFFSTACK is set. Check for the return value and WARN() on >> failure >> of an allocation in such cases. > > And that

Re: [RFC PATCH] smpboot: Check for successfull allocation of cpumask vars

2014-12-09 Thread Thomas Gleixner
On Tue, 9 Dec 2014, Pranith Kumar wrote: > zalloc_cpumask_var() can return 0 on allocation failure when > CONFIG_CPUMASK_OFFSTACK is set. Check for the return value and WARN() on > failure > of an allocation in such cases. And that warning helps in which way? It just prints a completely useless

[RFC PATCH] smpboot: Check for successfull allocation of cpumask vars

2014-12-09 Thread Pranith Kumar
zalloc_cpumask_var() can return 0 on allocation failure when CONFIG_CPUMASK_OFFSTACK is set. Check for the return value and WARN() on failure of an allocation in such cases. Signed-off-by: Pranith Kumar --- arch/x86/kernel/smpboot.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-