On Tue, Dec 9, 2014 at 3:10 PM, Thomas Gleixner <t...@linutronix.de> wrote: > On Tue, 9 Dec 2014, Pranith Kumar wrote: >> zalloc_cpumask_var() can return 0 on allocation failure when >> CONFIG_CPUMASK_OFFSTACK is set. Check for the return value and WARN() on >> failure >> of an allocation in such cases. > > And that warning helps in which way? > > It just prints a completely useless backtrace and breaks out of the > loop, but it does not prevent that later on code will trip over the > non allocated per cpu data. >
I agree. May be just a pr_warn() saying that an allocation failed perhaps? To prevent further accesses, we can clear the cpu bit from the cpu masks(online/possible/present) for the failed cpu and continue trying to allocate for other cpus. We don't break out of the loop. Removing the cpu from the cpu masks will disable accesses of the non allocated per cpu data. What do you suggest we do in such cases? -- Pranith -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
