Re: [RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-31 Thread Srinivasa Ds
Rusty Russell wrote: Subject: Don't report discarded init pages as kernel text. Current code could cause a bug in symbol_put_addr() if an arch used kmalloc module text: we might think the symbol belongs to the core kernel. The downside is that this might make backtraces through (discarded) in

Re: [RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-18 Thread Rusty Russell
On Tuesday 18 December 2007 18:23:53 Rusty Russell wrote: > On Tuesday 18 December 2007 17:46:15 Srinivasa Ds wrote: > > Rusty Russell wrote: > > > The downside is that this might make backtraces through (discarded) > > > init functions harder to read on some archs. > > > > I think it is better to

Re: [RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-17 Thread Rusty Russell
On Tuesday 18 December 2007 17:46:15 Srinivasa Ds wrote: > Rusty Russell wrote: > > On Friday 14 December 2007 18:51:06 Ananth N Mavinakayanahalli wrote: > >> On Thu, Dec 13, 2007 at 11:09:16PM -0800, Andrew Morton wrote: > >>> regular_kernel_text_address()? Dunno. > >> > >> Sounds better :-) > >

Re: [RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-17 Thread Srinivasa Ds
Rusty Russell wrote: On Friday 14 December 2007 18:51:06 Ananth N Mavinakayanahalli wrote: On Thu, Dec 13, 2007 at 11:09:16PM -0800, Andrew Morton wrote: regular_kernel_text_address()? Dunno. Sounds better :-) The better answer was to invert it and use "discarded_kernel_text_address()", whi

Re: [RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-17 Thread Rusty Russell
On Friday 14 December 2007 18:51:06 Ananth N Mavinakayanahalli wrote: > On Thu, Dec 13, 2007 at 11:09:16PM -0800, Andrew Morton wrote: > > regular_kernel_text_address()? Dunno. > > Sounds better :-) The better answer was to invert it and use "discarded_kernel_text_address()", which is what you ac

[RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-17 Thread Srinivasa Ds
Changing regular_kernel_text_address() to persistent_kernel_text_address(). Since __init functions are discarded and its memory freed once initialization completes, It would be better if we enable kprobes to refuse probing __init functions. The attached patchset will do that. This patch creates p

Re: [RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-14 Thread Johannes Weiner
Hi, Srinivasa Ds <[EMAIL PROTECTED]> writes: > Forgot to change non_init_core_kernel_text() to regular_core_kernel_text(). > Resending the patch. > > [...] > > This patch creates non_init_kernel_text_address() to identify > non_init text area. You still refer to the old name here :) How about p

Re: [RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-14 Thread Srinivasa Ds
Forgot to change non_init_core_kernel_text() to regular_core_kernel_text(). Resending the patch. Since __init functions are discarded and its memory freed once initialization completes, It would be better if we enable kprobes to refuse probing __init functions. The attached patchset will do that

Re: [RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-14 Thread Srinivasa Ds
Resending the patch, by changing the name as suggested by Andrew. Since __init functions are discarded and its memory freed once initialization completes, It would be better if we enable kprobes to refuse probing __init functions. The attached patchset will do that. This patch creates non_init_

Re: [RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-13 Thread Ananth N Mavinakayanahalli
On Thu, Dec 13, 2007 at 11:09:16PM -0800, Andrew Morton wrote: > On Fri, 14 Dec 2007 12:25:30 +0530 Srinivasa Ds <[EMAIL PROTECTED]> wrote: > > > Since __init functions are discarded and its memory freed once > > initialization completes, It would be better if we enable kprobes > > to refuse prob

Re: [RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-13 Thread Andrew Morton
On Fri, 14 Dec 2007 12:25:30 +0530 Srinivasa Ds <[EMAIL PROTECTED]> wrote: > Since __init functions are discarded and its memory freed once > initialization completes, It would be better if we enable kprobes > to refuse probing __init functions. The attached patchset will do > that. > > This pa

[RFC] [patch 1/2] add non_init_kernel_text_address

2007-12-13 Thread Srinivasa Ds
Since __init functions are discarded and its memory freed once initialization completes, It would be better if we enable kprobes to refuse probing __init functions. The attached patchset will do that. This patch creates non_init_kernel_text_address() to identify non_init text area. Iam open to