On Friday 14 December 2007 18:51:06 Ananth N Mavinakayanahalli wrote: > On Thu, Dec 13, 2007 at 11:09:16PM -0800, Andrew Morton wrote: > > regular_kernel_text_address()? Dunno. > > Sounds better :-)
The better answer was to invert it and use "discarded_kernel_text_address()", which is what you actually care about (rather than the details of whether it was init or not). However, you have, in fact, located a potential bug. If someone were to kmalloc module text, then symbol_put() could fail. How's this? --- Don't report discarded init pages as kernel text. In theory this could cause a bug in symbol_put() if an arch used for a module: we might think the symbol belongs to the core kernel. The downside is that this might make backtraces through (discarded) init functions harder to read on some archs. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 0eabf082c13a kernel/extable.c --- a/kernel/extable.c Tue Dec 18 13:51:13 2007 +1100 +++ b/kernel/extable.c Tue Dec 18 15:53:01 2007 +1100 @@ -46,7 +46,8 @@ int core_kernel_text(unsigned long addr) addr <= (unsigned long)_etext) return 1; - if (addr >= (unsigned long)_sinittext && + if (system_state == SYSTEM_BOOTING && + addr >= (unsigned long)_sinittext && addr <= (unsigned long)_einittext) return 1; return 0; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/