Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-18 Thread KOSAKI Motohiro
Hi! > > 1. I doubt ZONE_DMA, please shipment ignore zone_dma patch(below). > > Your patch above solves the problem I had with early notification. really!? I am really happy!! Thanks you. - kosaki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-18 Thread Daniel Spång
On 1/17/08, KOSAKI Motohiro <[EMAIL PROTECTED]> wrote: > Hi Daniel > > > > Thank you for good point out! > > > Could you please post your test program and reproduced method? > > > > Sure: > > > > 1. Fill almost all available memory with page cache in a system without > > swap. > > 2. Run attached

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-16 Thread KOSAKI Motohiro
Hi Daniel > > Thank you for good point out! > > Could you please post your test program and reproduced method? > > Sure: > > 1. Fill almost all available memory with page cache in a system without swap. > 2. Run attached alloc-test program. > 3. Notification fires when page cache is reclaimed.

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-16 Thread Daniel Spång
On 1/16/08, KOSAKI Motohiro <[EMAIL PROTECTED]> wrote: > Hi Daniel > > > > > The notification fires after only ~100 MB allocated, i.e., when page > > > > reclaim is beginning to nag from page cache. Isn't this a bit early? > > > > Repeating the test with swap enabled results in a notification after

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-15 Thread KOSAKI Motohiro
Hi Daniel > > > The notification fires after only ~100 MB allocated, i.e., when page > > > reclaim is beginning to nag from page cache. Isn't this a bit early? > > > Repeating the test with swap enabled results in a notification after > > > ~600 MB allocated, which is more reasonable and just befo

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-15 Thread Daniel Spång
On 1/15/08, Rik van Riel <[EMAIL PROTECTED]> wrote: > > On Tue, 15 Jan 2008 23:55:17 +0100 > "Daniel Spång" <[EMAIL PROTECTED]> wrote: > > > The notification fires after only ~100 MB allocated, i.e., when page > > reclaim is beginning to nag from page cache. Isn't this a bit early? > > Repeating th

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-15 Thread Rik van Riel
On Tue, 15 Jan 2008 23:55:17 +0100 "Daniel Spång" <[EMAIL PROTECTED]> wrote: > The notification fires after only ~100 MB allocated, i.e., when page > reclaim is beginning to nag from page cache. Isn't this a bit early? > Repeating the test with swap enabled results in a notification after > ~600 M

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-15 Thread Daniel Spång
Hi, On 1/15/08, KOSAKI Motohiro <[EMAIL PROTECTED]> wrote: > the notification point to happen whenever the VM moves an > anonymous page to the inactive list - this is a pretty good indication > that there are unused anonymous pages present which will be very likely > swapped out soon. > +

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-14 Thread KOSAKI Motohiro
Hi Kame, > > > > + notify_threshold = (zone->pages_high + > > > > + zone->lowmem_reserve[MAX_NR_ZONES-1]) * 2; > > > > + > > > Why MAX_NR_ZONES-1 ? > > > > this is intent to max lowmem_reserve. > > > Ah, my point is.. how about this ? > == > if (page_zoneid(page)

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-14 Thread KAMEZAWA Hiroyuki
On Tue, 15 Jan 2008 11:37:48 +0900 KOSAKI Motohiro <[EMAIL PROTECTED]> wrote: > Hi KAME, > > > > + notify_threshold = (zone->pages_high + > > > + zone->lowmem_reserve[MAX_NR_ZONES-1]) * 2; > > > + > > Why MAX_NR_ZONES-1 ? > > this is intent to max lowmem_reserve. > Ah, my p

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-14 Thread KOSAKI Motohiro
Hi KAME, > > + notify_threshold = (zone->pages_high + > > + zone->lowmem_reserve[MAX_NR_ZONES-1]) * 2; > > + > Why MAX_NR_ZONES-1 ? this is intent to max lowmem_reserve. in normal case, shrink_active_list isn't called when free_pages > pages_high. but just after memory

Re: [RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-14 Thread KAMEZAWA Hiroyuki
On Tue, 15 Jan 2008 10:02:30 +0900 KOSAKI Motohiro <[EMAIL PROTECTED]> wrote: > + > + notify_threshold = (zone->pages_high + > + zone->lowmem_reserve[MAX_NR_ZONES-1]) * 2; > + Why MAX_NR_ZONES-1 ? > + if (unlikely((prev_free <= notify_threshold) && > +

[RFC][PATCH 4/5] memory_pressure_notify() caller

2008-01-14 Thread KOSAKI Motohiro
the notification point to happen whenever the VM moves an anonymous page to the inactive list - this is a pretty good indication that there are unused anonymous pages present which will be very likely swapped out soon. and, It is judged out of trouble at the fllowing situations. o memory pressur