Hi Kame,

> > > > +       notify_threshold = (zone->pages_high +
> > > > +                           zone->lowmem_reserve[MAX_NR_ZONES-1]) * 2;
> > > > +
> > > Why MAX_NR_ZONES-1 ?
> > 
> > this is intent to max lowmem_reserve.
> > 
> Ah, my point is.. how about this ?
> ==
> if (page_zoneid(page) != ZONE_DMA)
>       notify_threshold = zone->pages_high +
>                       zone->lowmem_reserve[page_zoneid(page) - 1] * 2;

your point out is very good point.

but judged by zone size is more better, may be.
on some 64bit system, ZONE_DMA is 4GB.
small memory system can't ignore it. 

fortunately, zone size check can at free_area_init_core().


- kosaki



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to