Re: [PATCHv3 3/7] perf tools: Fine tune readn function

2013-11-28 Thread David Ahern
On 11/28/13, 8:43 AM, Jiri Olsa wrote: - if (ret <= 0) + if ((ret <= 0) && (errno != EINTR)) return ret; I think you want: if (ret < 0 && errno == EINTR) continue; if (ret <= 0) return ret; You certainly do not want ret < 0

[PATCHv3 3/7] perf tools: Fine tune readn function

2013-11-28 Thread Jiri Olsa
On Thu, Nov 28, 2013 at 08:19:51AM -0700, David Ahern wrote: > On 11/28/13, 3:30 AM, Jiri Olsa wrote: > >@@ -151,21 +152,26 @@ unsigned long convert_unit(unsigned long value, char > >*unit) > > return value; > > } > > > >+/* > >+ * Read exactly 'n' bytes or return an error. > >+ */ > > ssize