Re: [PATCHv3 3/7] perf tools: Fine tune readn function

[David Ahern]

On 11/28/13, 8:43 AM, Jiri Olsa wrote:

-               if (ret <= 0)
+               if ((ret <= 0) && (errno != EINTR))
                        return ret;

I think you want:
if (ret < 0 && errno == EINTR)
        continue;

if (ret <= 0)
        return ret;

You certainly do not want ret < 0 here: ;-)

-               n -= ret;
-               buf += ret;
+               left -= ret;
+               buf  += ret;
        }

-       return buf - buf_start;
+       BUG_ON((size_t)(buf - buf_start) != n);
+       return n;
  }

  size_t hex_width(u64 v)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/