RE: [PATCHv3 2/2] watchdog: imx2_wdt: convert to use regmap API.

2014-04-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv3 2/2] watchdog: imx2_wdt: convert to use regmap API. > > On Tue, Apr 01, 2014 at 12:46:38PM +0800, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > Cc: Guenter Roeck > > We should probably have some commit log to explain why we need to move &

Re: [PATCHv3 2/2] watchdog: imx2_wdt: convert to use regmap API.

2014-04-02 Thread Guenter Roeck
On 03/31/2014 09:46 PM, Xiubo Li wrote: Signed-off-by: Xiubo Li Cc: Guenter Roeck --- Agreed with the other e-mail (an explanation would be useful). Other than that, looks good to me. Reviewed-by: Guenter Roeck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCHv3 2/2] watchdog: imx2_wdt: convert to use regmap API.

2014-04-02 Thread Shawn Guo
On Tue, Apr 01, 2014 at 12:46:38PM +0800, Xiubo Li wrote: > Signed-off-by: Xiubo Li > Cc: Guenter Roeck We should probably have some commit log to explain why we need to move to use regmap API. Shawn > --- > drivers/watchdog/imx2_wdt.c | 50 > + >

[PATCHv3 2/2] watchdog: imx2_wdt: convert to use regmap API.

2014-03-31 Thread Xiubo Li
Signed-off-by: Xiubo Li Cc: Guenter Roeck --- drivers/watchdog/imx2_wdt.c | 50 + 1 file changed, 32 insertions(+), 18 deletions(-) diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c index 1795922..76fa724 100644 --- a/drivers/watc