Re: [PATCHv3 02/11] arm64: Handle section maps for swapper/idmap

2015-10-14 Thread Mark Rutland
On Wed, Oct 14, 2015 at 04:08:43PM +0100, Suzuki K. Poulose wrote: > On 14/10/15 15:51, Mark Rutland wrote: > +/* With 4K pages, we use section maps. */ > > >>/* > >> * ARM64 kernel is guaranteed to be loaded at 2M aligned > >> * address (as per booting requirements). Hence we can use > >>

Re: [PATCHv3 02/11] arm64: Handle section maps for swapper/idmap

2015-10-14 Thread Suzuki K. Poulose
On 14/10/15 15:51, Mark Rutland wrote: +/* With 4K pages, we use section maps. */ /* * ARM64 kernel is guaranteed to be loaded at 2M aligned * address (as per booting requirements). Hence we can use * section mapping with 4K (section size = 2M) and not with * 16K(section size = 32M) or

Re: [PATCHv3 02/11] arm64: Handle section maps for swapper/idmap

2015-10-14 Thread Mark Rutland
> >>+/* With 4K pages, we use section maps. */ > >>+#ifdef CONFIG_ARM64_4K_PAGES > >>+#define ARM64_SWAPPER_USES_SECTION_MAPS 1 > >>+#else > >>+#define ARM64_SWAPPER_USES_SECTION_MAPS 0 > >>+#endif > > > >The comment is somewhat redunant. It would be better to state why we do > >this for 4K and not

Re: [PATCHv3 02/11] arm64: Handle section maps for swapper/idmap

2015-10-14 Thread Suzuki K. Poulose
On 14/10/15 13:06, Mark Rutland wrote: On Wed, Oct 14, 2015 at 12:20:25PM +0100, Suzuki K. Poulose wrote: We use section maps with 4K page size to create the swapper/idmaps. So far we have used !64K or 4K checks to handle the case where we use the section maps. This patch adds a new symbol, ARM6

Re: [PATCHv3 02/11] arm64: Handle section maps for swapper/idmap

2015-10-14 Thread Mark Rutland
On Wed, Oct 14, 2015 at 12:20:25PM +0100, Suzuki K. Poulose wrote: > We use section maps with 4K page size to create the swapper/idmaps. > So far we have used !64K or 4K checks to handle the case where we > use the section maps. > This patch adds a new symbol, ARM64_SWAPPER_USES_SECTION_MAPS, to >

[PATCHv3 02/11] arm64: Handle section maps for swapper/idmap

2015-10-14 Thread Suzuki K. Poulose
We use section maps with 4K page size to create the swapper/idmaps. So far we have used !64K or 4K checks to handle the case where we use the section maps. This patch adds a new symbol, ARM64_SWAPPER_USES_SECTION_MAPS, to handle cases where we use section maps, instead of using the page size symbol