On Wed, Oct 14, 2015 at 04:08:43PM +0100, Suzuki K. Poulose wrote: > On 14/10/15 15:51, Mark Rutland wrote: > >>>>+/* With 4K pages, we use section maps. */ > > >>/* > >> * ARM64 kernel is guaranteed to be loaded at 2M aligned > >> * address (as per booting requirements). Hence we can use > >> * section mapping with 4K (section size = 2M) and not with > >> * 16K(section size = 32M) or 64K (section size = 512M). > >> */ > > > >That sounds much better. I hadn't figured out why myself, so thanks for > >the explanation :) > > > >However, there's one minor nit: the start of memory below the kernel is > >2M aligned, but the offset means that the kernel itself is not loaded at > >a 2M aligned address. > > Oh yes > > > > >So how about: > > > >/* > > * The linear mapping and the start of memory are both 2M aligned (per > > * the arm64 booting.txt requirements). Hence we can use section mapping > > * with 4K (section size = 2M) but not with 16K (section size = 32M) or > > * 64K (section size = 512M). > > */ > > Will add this
Great. FWIW, with the changes from this thread applied: Acked-by: Mark Rutland <mark.rutl...@arm.com> Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
