Re: [PATCHSET 2.6.22-rc4] sysfs: fix race conditions

2007-06-12 Thread Tejun Heo
Greg KH wrote: > On Mon, Jun 11, 2007 at 03:15:39PM +0900, Tejun Heo wrote: >> Andrew Morton wrote: This patchset contains three minimal backports of fixes in -mm. With all patches in the patchset and sysfs-races.patch applied, kernel survived ~20 hours of stress test without any pr

Re: [PATCHSET 2.6.22-rc4] sysfs: fix race conditions

2007-06-12 Thread Greg KH
On Mon, Jun 11, 2007 at 03:15:39PM +0900, Tejun Heo wrote: > Andrew Morton wrote: > >> This patchset contains three minimal backports of fixes in -mm. With > >> all patches in the patchset and sysfs-races.patch applied, kernel > >> survived ~20 hours of stress test without any problem. > > > > So

Re: [PATCHSET 2.6.22-rc4] sysfs: fix race conditions

2007-06-11 Thread Greg KH
On Mon, Jun 11, 2007 at 03:15:39PM +0900, Tejun Heo wrote: > Andrew Morton wrote: > >> This patchset contains three minimal backports of fixes in -mm. With > >> all patches in the patchset and sysfs-races.patch applied, kernel > >> survived ~20 hours of stress test without any problem. > > > > So

Re: [PATCHSET 2.6.22-rc4] sysfs: fix race conditions

2007-06-11 Thread Eduard-Gabriel Munteanu
*This message was transferred with a trial version of CommuniGate(r) Pro* Tejun Heo wrote: Dude, what are you smoking and can I get some? The attached patch is to trigger the race conditions more easily for verification. Actual fixes are in the three patches posted as reply to the head message.

Re: [PATCHSET 2.6.22-rc4] sysfs: fix race conditions

2007-06-11 Thread Tejun Heo
Eduard-Gabriel Munteanu wrote: > *This message was transferred with a trial version of CommuniGate(r) Pro* > Tejun Heo wrote: > >> This patchset contains three minimal backports of fixes in -mm. With >> all patches in the patchset and sysfs-races.patch applied, kernel >> survived ~20 hours of str

Re: [PATCHSET 2.6.22-rc4] sysfs: fix race conditions

2007-06-11 Thread Eduard-Gabriel Munteanu
*This message was transferred with a trial version of CommuniGate(r) Pro* Tejun Heo wrote: This patchset contains three minimal backports of fixes in -mm. With all patches in the patchset and sysfs-races.patch applied, kernel survived ~20 hours of stress test without any problem. Seriously,

Re: [PATCHSET 2.6.22-rc4] sysfs: fix race conditions

2007-06-10 Thread Tejun Heo
Andrew Morton wrote: >> This patchset contains three minimal backports of fixes in -mm. With >> all patches in the patchset and sysfs-races.patch applied, kernel >> survived ~20 hours of stress test without any problem. > > So these are being proposed for 2.6.22? Yeap. > I do wonder about Rafae

Re: [PATCHSET 2.6.22-rc4] sysfs: fix race conditions

2007-06-10 Thread Andrew Morton
On Mon, 11 Jun 2007 14:01:07 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Currently, there are several race conditions around dentry/inode > reclamation. > > a. sysfs_dirent->s_dentry dereferencing in sysfs_readdir() > > b. sysfs_dirent->s_dentry dereferencing in sysfs_drop_dentry() > > c. sysf

[PATCHSET 2.6.22-rc4] sysfs: fix race conditions

2007-06-10 Thread Tejun Heo
Hello, all. Currently, there are several race conditions around dentry/inode reclamation. a. sysfs_dirent->s_dentry dereferencing in sysfs_readdir() b. sysfs_dirent->s_dentry dereferencing in sysfs_drop_dentry() c. sysfs_dirent->s_dentry clearing in sysfs_d_iput() All aboves are done without s