Re: [PATCH v5 5/5] i2c:ocores: checkpatch fixes

2019-02-11 Thread Wolfram Sang
> > - oc_setreg(i2c, OCI2C_CONTROL, ctrl & ~(OCI2C_CTRL_EN|OCI2C_CTRL_IEN)); > > + ctrl = oc_getreg(i2c, OCI2C_CONTROL); > > There's a pointless double oc_getreg(i2c, OCI2C_CONTROL). In case you need to resend, please update $subject of all patches to have a space after "i2c:" signature.a

Re: [PATCH v5 5/5] i2c:ocores: checkpatch fixes

2019-02-11 Thread Federico Vaga
On Monday, February 11, 2019 5:12:23 PM CET Peter Rosin wrote: > On 2019-02-11 17:05, Federico Vaga wrote: > > > Miscellaneous style fixes from checkpatch > > > > Signed-off-by: Federico Vaga > > --- > > > > drivers/i2c/busses/i2c-ocores.c | 30 +++--- > > 1 file change

Re: [PATCH v5 5/5] i2c:ocores: checkpatch fixes

2019-02-11 Thread Peter Rosin
On 2019-02-11 17:05, Federico Vaga wrote: > Miscellaneous style fixes from checkpatch > > Signed-off-by: Federico Vaga > --- > drivers/i2c/busses/i2c-ocores.c | 30 +++--- > 1 file changed, 19 insertions(+), 11 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-ocores.

[PATCH v5 5/5] i2c:ocores: checkpatch fixes

2019-02-11 Thread Federico Vaga
Miscellaneous style fixes from checkpatch Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c index 78085a8..54b2156