Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-04-01 Thread Masahiro Yamada
Hi Emese, Sorry for my late reply. > Thanks for the patch. I tested it and there is a problem when I run a > parallel make. > The plugins are compiled later than needed (e.g., scripts/mod/empty.o). There > is a lot of important > code under scripts/mod which may need the plugins. Ah, I missed

Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-03-27 Thread Emese Revfy
On Sat, 26 Mar 2016 11:39:32 +0900 Masahiro Yamada wrote: > > I tried to remove the gcc-plugins target but sadly in this case the plugins > > aren't complied. > > I don't know if I understand how it should work. I pushed a commit: > > https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/c

Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-03-25 Thread Masahiro Yamada
Hi Emese, 2016-03-24 9:07 GMT+09:00 Emese Revfy : > On Fri, 11 Mar 2016 15:25:19 +0900 > Masahiro Yamada wrote: > >> You sprinkle "gcc-plugins" target in the top Makefile, which I do not like. >> >> Can you descend into scripts/gcc-plugins from scripts/Makefile? >> >> >> subdir-$(CONFIG_MODVER

Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-03-23 Thread Emese Revfy
On Fri, 11 Mar 2016 15:25:19 +0900 Masahiro Yamada wrote: > You sprinkle "gcc-plugins" target in the top Makefile, which I do not like. > > Can you descend into scripts/gcc-plugins from scripts/Makefile? > > > subdir-$(CONFIG_MODVERSIONS) += genksyms > subdir-y += mod >

Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-03-19 Thread Emese Revfy
On Wed, 16 Mar 2016 16:41:36 +0900 Masahiro Yamada wrote: > > The scripts name also doesn't describe gcc plugins well. > > With my suggestion "scripts/gcc-plugins/", > the sub-directory name describes it very well. > > > > Plugins take part in the image building process > > in a different way

Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-03-19 Thread Masahiro Yamada
2016-03-16 21:49 GMT+09:00 PaX Team : > On 16 Mar 2016 at 16:34, Masahiro Yamada wrote: > > Hi, > >> >> As mentioned above, I want you to use "..." style >> >> when you need to use relative path from the source. >> >> >> >> I do not see most of them in tools/gcc/. >> > >> > no, that'd be incorrect

Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-03-19 Thread PaX Team
On 16 Mar 2016 at 16:34, Masahiro Yamada wrote: Hi, > >> As mentioned above, I want you to use "..." style > >> when you need to use relative path from the source. > >> > >> I do not see most of them in tools/gcc/. > > > > no, that'd be incorrect for several reasons. first, the rule to use <...>

Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-03-16 Thread Masahiro Yamada
Hi Emese, 2016-03-15 5:52 GMT+09:00 Emese Revfy : > On Fri, 11 Mar 2016 15:25:19 +0900 > Masahiro Yamada wrote: > >> Maybe scripts/gcc-plugins/ is better than tools/gcc ? >> >> In the directory "scripts/", we have several tools used during >> building the kernel image. >> We have some optional pr

Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-03-16 Thread Masahiro Yamada
Hi PaX, 2016-03-15 6:25 GMT+09:00 PaX Team : > On 11 Mar 2016 at 15:25, Masahiro Yamada wrote: > >> > diff --git a/scripts/gcc-plugin.sh b/scripts/gcc-plugin.sh >> > new file mode 100644 >> > index 000..eaa4fce >> > --- /dev/null >> > +++ b/scripts/gcc-plugin.sh >> > @@ -0,0 +1,51 @@ >> > +#!

Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-03-14 Thread PaX Team
On 11 Mar 2016 at 15:25, Masahiro Yamada wrote: > > diff --git a/scripts/gcc-plugin.sh b/scripts/gcc-plugin.sh > > new file mode 100644 > > index 000..eaa4fce > > --- /dev/null > > +++ b/scripts/gcc-plugin.sh > > @@ -0,0 +1,51 @@ > > +#!/bin/sh > > +srctree=$(dirname "$0") > > +gccplugins_dir=

Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-03-14 Thread Emese Revfy
On Fri, 11 Mar 2016 15:25:19 +0900 Masahiro Yamada wrote: > Maybe scripts/gcc-plugins/ is better than tools/gcc ? > > In the directory "scripts/", we have several tools used during > building the kernel image. > We have some optional programs in the directory "tools/", which are not used > for b

Re: [PATCH v5 2/5] GCC plugin infrastructure

2016-03-10 Thread Masahiro Yamada
Hi Emese, I am not familiar with GCC plugins. Comments from the view of Kbuild. 2016-03-07 8:04 GMT+09:00 Emese Revfy : > This patch allows to build the whole kernel with GCC plugins. It was ported > from > grsecurity/PaX. The infrastructure supports building out-of-tree modules and > building

Re: [kernel-hardening] [PATCH v5 2/5] GCC plugin infrastructure

2016-03-09 Thread Emese Revfy
On Wed, 9 Mar 2016 12:50:26 -0800 Kees Cook wrote: > > Feel free to fold these into your patch, or, if you prefer, I can send > > out separate patches for them. > > Ah-ha, great! Thanks for testing! > > Emese, if you're not interested in carrying this, I can add it to my tree. I think it is ea

Re: [kernel-hardening] [PATCH v5 2/5] GCC plugin infrastructure

2016-03-09 Thread Emese Revfy
On Wed, 9 Mar 2016 02:01:15 -0700 David Brown wrote: > Feel free to fold these into your patch, or, if you prefer, I can send > out separate patches for them. Thanks, I'll take it. -- Emese

Re: [kernel-hardening] [PATCH v5 2/5] GCC plugin infrastructure

2016-03-09 Thread Kees Cook
On Wed, Mar 9, 2016 at 1:01 AM, David Brown wrote: > On Mon, Mar 07, 2016 at 12:04:27AM +0100, Emese Revfy wrote: > >> This patch allows to build the whole kernel with GCC plugins. It was >> ported from >> grsecurity/PaX. The infrastructure supports building out-of-tree modules >> and >> building

Re: [kernel-hardening] [PATCH v5 2/5] GCC plugin infrastructure

2016-03-09 Thread David Brown
On Mon, Mar 07, 2016 at 12:04:27AM +0100, Emese Revfy wrote: This patch allows to build the whole kernel with GCC plugins. It was ported from grsecurity/PaX. The infrastructure supports building out-of-tree modules and building in a separate directory. Cross-compilation is supported too but curr

[PATCH v5 2/5] GCC plugin infrastructure

2016-03-06 Thread Emese Revfy
This patch allows to build the whole kernel with GCC plugins. It was ported from grsecurity/PaX. The infrastructure supports building out-of-tree modules and building in a separate directory. Cross-compilation is supported too but currently only the x86 architecture enables plugins. The directory