Re: [PATCH v5 04/18] slab: don't preemptively remove element from list in cache destroy

2012-10-24 Thread Glauber Costa
On 10/24/2012 10:54 AM, Pekka Enberg wrote: > On Mon, Oct 22, 2012 at 11:40 AM, Glauber Costa wrote: >> On 10/19/2012 11:34 PM, Christoph Lameter wrote: >>> On Fri, 19 Oct 2012, Glauber Costa wrote: >>> I, however, see no reason why we need to do so, since we are now locked during the wh

Re: [PATCH v5 04/18] slab: don't preemptively remove element from list in cache destroy

2012-10-23 Thread Pekka Enberg
On Mon, Oct 22, 2012 at 11:40 AM, Glauber Costa wrote: > On 10/19/2012 11:34 PM, Christoph Lameter wrote: >> On Fri, 19 Oct 2012, Glauber Costa wrote: >> >>> I, however, see no reason why we need to do so, since we are now locked >>> during the whole deletion (which wasn't necessarily true before)

Re: [PATCH v5 04/18] slab: don't preemptively remove element from list in cache destroy

2012-10-22 Thread Glauber Costa
On 10/19/2012 11:34 PM, Christoph Lameter wrote: > On Fri, 19 Oct 2012, Glauber Costa wrote: > >> I, however, see no reason why we need to do so, since we are now locked >> during the whole deletion (which wasn't necessarily true before). I >> propose a simplification in which we delete it only w

Re: [PATCH v5 04/18] slab: don't preemptively remove element from list in cache destroy

2012-10-19 Thread Christoph Lameter
On Fri, 19 Oct 2012, Glauber Costa wrote: > I, however, see no reason why we need to do so, since we are now locked > during the whole deletion (which wasn't necessarily true before). I > propose a simplification in which we delete it only when there is no > more going back, so we don't need to a

[PATCH v5 04/18] slab: don't preemptively remove element from list in cache destroy

2012-10-19 Thread Glauber Costa
After the slab/slub/slob merge, we are deleting the element from the slab_cache lists, and then if the destruction fail, we add it back again. This behavior was present in some caches, but not in others, if my memory doesn't fail me. I, however, see no reason why we need to do so, since we are now