Re: [PATCH v5] checkpatch: add new exception to repeated word check

2020-10-18 Thread Joe Perches
On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote: > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") > moved the repeated word test to check for more file types. But after > this, if checkpatch.pl is run on MAINTAINERS, it generates several > new warnings of the type: An

Re: [PATCH v5] checkpatch: add new exception to repeated word check

2020-10-18 Thread Dwaipayan Ray
On Sun, Oct 18, 2020 at 12:41 PM Joe Perches wrote: > > On Sun, 2020-10-18 at 12:10 +0530, Dwaipayan Ray wrote: > > print index(" \t.,;?!", ''); > > > > It output 0 in my case. So last words on a line seems to work. > > I don't know if this changes with the perl version though. > > > > So given th

Re: [PATCH v5] checkpatch: add new exception to repeated word check

2020-10-18 Thread Joe Perches
On Sun, 2020-10-18 at 12:10 +0530, Dwaipayan Ray wrote: > print index(" \t.,;?!", ''); > > It output 0 in my case. So last words on a line seems to work. > I don't know if this changes with the perl version though. > > So given this, will it be necessary to change end_char to ' ' ? > or perhaps c

Re: [PATCH v5] checkpatch: add new exception to repeated word check

2020-10-17 Thread Dwaipayan Ray
On Sun, Oct 18, 2020 at 11:50 AM Joe Perches wrote: > > On Sat, 2020-10-17 at 22:19 +0530, Dwaipayan Ray wrote: > > On Sat, Oct 17, 2020 at 10:03 PM Joe Perches wrote: > > > On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote: > > > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated w

Re: [PATCH v5] checkpatch: add new exception to repeated word check

2020-10-17 Thread Joe Perches
On Sat, 2020-10-17 at 22:19 +0530, Dwaipayan Ray wrote: > On Sat, Oct 17, 2020 at 10:03 PM Joe Perches wrote: > > On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote: > > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") > > > moved the repeated word test to check for more

Re: [PATCH v5] checkpatch: add new exception to repeated word check

2020-10-17 Thread Dwaipayan Ray
On Sat, Oct 17, 2020 at 10:03 PM Joe Perches wrote: > > On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote: > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") > > moved the repeated word test to check for more file types. But after > > this, if checkpatch.pl is run on MA

Re: [PATCH v5] checkpatch: add new exception to repeated word check

2020-10-17 Thread Joe Perches
On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote: > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") > moved the repeated word test to check for more file types. But after > this, if checkpatch.pl is run on MAINTAINERS, it generates several > new warnings of the type: NA

[PATCH v5] checkpatch: add new exception to repeated word check

2020-10-17 Thread Dwaipayan Ray
Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") moved the repeated word test to check for more file types. But after this, if checkpatch.pl is run on MAINTAINERS, it generates several new warnings of the type: WARNING: Possible repeated word: 'git' For example: WARNING: Poss