On Sat, 2020-10-17 at 22:19 +0530, Dwaipayan Ray wrote:
> On Sat, Oct 17, 2020 at 10:03 PM Joe Perches <j...@perches.com> wrote:
> > On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote:
> > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test")
> > > moved the repeated word test to check for more file types. But after
> > > this, if checkpatch.pl is run on MAINTAINERS, it generates several
> > > new warnings of the type:
> >
> > NAK.
> >
> > Slow down and test before you send more patch versions.
> >
> > > + next if (index(" \t.,;?!", $end_char) ==
> > > -1);
> >
> > what does this do?
>
> Um, it checks if end_char is not present in " \t.,;?!".
> If end_char doesn't belong to this list, then the check shall
> skip. That is the test will skip for "word word:", but will produce
> a warning for "word word." or "word word?", etc.
>
> Shouldn't this itself be the case or am I perhaps going wrong
> somewhere?
No, you were right, I was being a numbskull.
btw: I think this should set
my $end_char = ' ';
not ''
so that if the last word on a line is a
repeat the test still works.
