Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

2016-06-29 Thread Keerthy
On Wednesday 29 June 2016 04:15 PM, Manish Badarkhe wrote: Hi Keerthy, sorry ignore my last two comments in previous mail. On Wed, Jun 29, 2016 at 4:13 PM, Manish Badarkhe wrote: Hi Keerthy Some minor comment +static int lp873x_gpio_direction_output(struct gpio_chip *chip, +

Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

2016-06-29 Thread Manish Badarkhe
Hi Keerthy, sorry ignore my last two comments in previous mail. On Wed, Jun 29, 2016 at 4:13 PM, Manish Badarkhe wrote: > Hi Keerthy > > Some minor comment > >> +static int lp873x_gpio_direction_output(struct gpio_chip *chip, >> + unsigned int offset, int va

Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

2016-06-29 Thread Manish Badarkhe
Hi Keerthy Some minor comment > +static int lp873x_gpio_direction_output(struct gpio_chip *chip, > + unsigned int offset, int value) > +{ > + struct lp873x_gpio *gpio = gpiochip_get_data(chip); > + > + /* Set the initial value */ > + regmap_

[PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

2016-06-29 Thread Keerthy
Add driver for lp873x PMIC family GPOs. Two GPOs are supported and can be configured in Open-drain output or Push-pull output. Signed-off-by: Keerthy --- drivers/gpio/Kconfig | 10 +++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-lp873x.c | 188 +++