Hi Keerthy, sorry ignore my last two comments in previous mail.
On Wed, Jun 29, 2016 at 4:13 PM, Manish Badarkhe <[email protected]> wrote: > Hi Keerthy > > Some minor comment > >> +static int lp873x_gpio_direction_output(struct gpio_chip *chip, >> + unsigned int offset, int value) >> +{ >> + struct lp873x_gpio *gpio = gpiochip_get_data(chip); >> + >> + /* Set the initial value */ >> + regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL, >> + BIT(offset * 4), value ? BIT(offset * 4) : 0); >> + >> + return 0; >> +} Error needs to be return, this function always return 0. Regards Manish Badarkhe
