Re: [PATCH v4 2/5] x86/umwait: Initialize umwait control values

2019-06-18 Thread Thomas Gleixner
On Mon, 17 Jun 2019, Fenghua Yu wrote: > On Tue, Jun 11, 2019 at 10:46:55PM +0200, Thomas Gleixner wrote: > > On Sun, 9 Jun 2019, Fenghua Yu wrote: > > > > Sounds good, but: > > > > > > > > > +#define MSR_IA32_UMWAIT_CONTROL_C02BIT(0) > > > > > > > > > +static u32 umwait_control_cache

Re: [PATCH v4 2/5] x86/umwait: Initialize umwait control values

2019-06-17 Thread Fenghua Yu
On Tue, Jun 11, 2019 at 10:46:55PM +0200, Thomas Gleixner wrote: > On Sun, 9 Jun 2019, Fenghua Yu wrote: > > > On Sat, Jun 08, 2019 at 03:52:42PM -0700, Andy Lutomirski wrote: > > > On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > > > > > > > umwait or tpause allows processor to enter a light

Re: [PATCH v4 2/5] x86/umwait: Initialize umwait control values

2019-06-11 Thread Thomas Gleixner
On Sun, 9 Jun 2019, Fenghua Yu wrote: > On Sat, Jun 08, 2019 at 03:52:42PM -0700, Andy Lutomirski wrote: > > On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > > > > > umwait or tpause allows processor to enter a light-weight > > > power/performance optimized state (C0.1 state) or an improved >

Re: [PATCH v4 2/5] x86/umwait: Initialize umwait control values

2019-06-11 Thread Fenghua Yu
On Tue, Jun 11, 2019 at 10:50:36AM +0200, Peter Zijlstra wrote: > On Fri, Jun 07, 2019 at 03:00:34PM -0700, Fenghua Yu wrote: > > umwait or tpause allows processor to enter a light-weight > > power/performance optimized state (C0.1 state) or an improved > > power/performance optimized state (C0.2 s

Re: [PATCH v4 2/5] x86/umwait: Initialize umwait control values

2019-06-11 Thread Peter Zijlstra
On Fri, Jun 07, 2019 at 03:00:34PM -0700, Fenghua Yu wrote: > umwait or tpause allows processor to enter a light-weight > power/performance optimized state (C0.1 state) or an improved > power/performance optimized state (C0.2 state) for a period > specified by the instruction or until the system ti

Re: [PATCH v4 2/5] x86/umwait: Initialize umwait control values

2019-06-09 Thread Andy Lutomirski
On Sun, Jun 9, 2019 at 9:23 PM Fenghua Yu wrote: > > On Sat, Jun 08, 2019 at 03:52:42PM -0700, Andy Lutomirski wrote: > > On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > > > > > umwait or tpause allows processor to enter a light-weight > > > power/performance optimized state (C0.1 state) or

Re: [PATCH v4 2/5] x86/umwait: Initialize umwait control values

2019-06-09 Thread Fenghua Yu
On Sat, Jun 08, 2019 at 03:52:42PM -0700, Andy Lutomirski wrote: > On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > > > umwait or tpause allows processor to enter a light-weight > > power/performance optimized state (C0.1 state) or an improved > > power/performance optimized state (C0.2 state)

Re: [PATCH v4 2/5] x86/umwait: Initialize umwait control values

2019-06-08 Thread Andy Lutomirski
On Fri, Jun 7, 2019 at 3:10 PM Fenghua Yu wrote: > > umwait or tpause allows processor to enter a light-weight > power/performance optimized state (C0.1 state) or an improved > power/performance optimized state (C0.2 state) for a period > specified by the instruction or until the system time limit

[PATCH v4 2/5] x86/umwait: Initialize umwait control values

2019-06-07 Thread Fenghua Yu
umwait or tpause allows processor to enter a light-weight power/performance optimized state (C0.1 state) or an improved power/performance optimized state (C0.2 state) for a period specified by the instruction or until the system time limit or until a store to the monitored address range in umwait.