Re: [PATCH v4 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-02 Thread Darek Marcinkiewicz
Hello. Thank you for your comments. On Thu, May 01, 2014 at 05:53:31PM +0200, Francois Romieu wrote: > Darek Marcinkiewicz : > [changes] > [...] > > > + > > +struct bh_priv { > > Nit: it would be nice to avoid "_bh_" as it is already used in a set of > common kernel functions. > I renamed bh

Re: [PATCH v4 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-01 Thread Francois Romieu
Darek Marcinkiewicz : [changes] (you may add those after the "---" above the diffstat) [...] > diff --git a/drivers/net/ethernet/ec_bh.c b/drivers/net/ethernet/ec_bh.c > new file mode 100644 > index 000..2ed2cee > --- /dev/null > +++ b/drivers/net/ethernet/ec_bh.c [...] > +#define TX_HEADER_

[PATCH v4 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-04-30 Thread Darek Marcinkiewicz
Changes since v3: * some clarificatoins around buffer allocations Changes since v2: * removed all checkpatch warnings * driver makes use of device rx fifo Changes since v1: * added endianess annotation to descriptors' structures * killed checkpath warnings about string literals being sp