Hello. Thank you for your comments.
On Thu, May 01, 2014 at 05:53:31PM +0200, Francois Romieu wrote:
> Darek Marcinkiewicz <rek...@newterm.pl> :
> [changes]
>
[...]
>
> > +
> > +struct bh_priv {
>
> Nit: it would be nice to avoid "_bh_" as it is already used in a set of
> common kernel functions.
>
I renamed bh to bhf and as result also changed the driver name - to ec_bhf.
> [...]
> > + u8 *tx_put;
> > + u8 *tx_get;
>
> It's part u8 and part tx_header.
>
> You may consider using a struct that adds an extra 'u8 data[0]' at
> the end of the struct tx_header.
>
> skb_copy_and_csum_dev in the xmit path rings a bell but the DMA FIFO
> zone handling could imho save some pointer arithmetic and turn a bit
> more literate.
>
I did some rework of descriptors handling and they are now kept in
a list so no pointer arithmetic at all.
As for the rest of your comments - all of them are incorporated
in next revision of the patch.
Thank you.
--
DM
--
DM
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
