Re: [PATCH v4] mm,writeback: fix divide by zero in pos_ratio_polynom

2014-04-30 Thread Rik van Riel
On 04/30/2014 04:13 PM, Andrew Morton wrote: On Wed, 30 Apr 2014 16:02:18 -0400 Rik van Riel wrote: I believe this should do the trick. ---8<--- Subject: mm,writeback: fix divide by zero in pos_ratio_polynom It is possible for "limit - setpoint + 1" to equal zero, leading to a divide by zer

Re: [PATCH v4] mm,writeback: fix divide by zero in pos_ratio_polynom

2014-04-30 Thread Andrew Morton
On Wed, 30 Apr 2014 16:02:18 -0400 Rik van Riel wrote: > I believe this should do the trick. > > ---8<--- > > Subject: mm,writeback: fix divide by zero in pos_ratio_polynom > > It is possible for "limit - setpoint + 1" to equal zero, leading to a > divide by zero error. Blindly adding 1 to "li

[PATCH v4] mm,writeback: fix divide by zero in pos_ratio_polynom

2014-04-30 Thread Rik van Riel
On Wed, 30 Apr 2014 12:35:26 -0700 Andrew Morton wrote: > > The easy way would be by calling div64_s64 and div64_u64, > > which are 64 bit all the way through. > > > > Any objections? > > Sounds good to me. > > > The inlined bits seem to be stubs calling the _rem variants > > of the functions,