Re: [PATCH v3 2/3] RISC-V: Add interrupt related SCAUSE defines in asm/csr.h

2019-04-24 Thread Anup Patel
On Wed, Apr 24, 2019 at 8:31 PM Christoph Hellwig wrote: > > On Wed, Apr 24, 2019 at 12:15:45PM +0530, Anup Patel wrote: > > We need these defines for programming HIDELEG CSR in KVM kernel module > > so it will be used at multiple places. > > > > > > > > http://git.infradead.org/users/hch/misc.git

Re: [PATCH v3 2/3] RISC-V: Add interrupt related SCAUSE defines in asm/csr.h

2019-04-24 Thread Christoph Hellwig
On Wed, Apr 24, 2019 at 12:15:45PM +0530, Anup Patel wrote: > We need these defines for programming HIDELEG CSR in KVM kernel module > so it will be used at multiple places. > > > > > http://git.infradead.org/users/hch/misc.git/commitdiff/1221f5c32345ebe7ea2c1cd6e8a01ad4b422aaba > > You can certa

Re: [PATCH v3 2/3] RISC-V: Add interrupt related SCAUSE defines in asm/csr.h

2019-04-23 Thread Anup Patel
On Wed, Apr 24, 2019 at 11:59 AM Christoph Hellwig wrote: > > On Mon, Apr 15, 2019 at 09:37:23AM +, Anup Patel wrote: > > This patch adds SCAUSE interrupt flag and SCAUSE interrupt related > > defines to asm/csr.h. We also use these defines in kernel/irq.c and > > express SIE/SIP flags in-term

Re: [PATCH v3 2/3] RISC-V: Add interrupt related SCAUSE defines in asm/csr.h

2019-04-23 Thread Christoph Hellwig
On Mon, Apr 15, 2019 at 09:37:23AM +, Anup Patel wrote: > This patch adds SCAUSE interrupt flag and SCAUSE interrupt related > defines to asm/csr.h. We also use these defines in kernel/irq.c and > express SIE/SIP flags in-terms of SCAUSE interrupt causes. I'm not a fan of this. For one this p

[PATCH v3 2/3] RISC-V: Add interrupt related SCAUSE defines in asm/csr.h

2019-04-15 Thread Anup Patel
This patch adds SCAUSE interrupt flag and SCAUSE interrupt related defines to asm/csr.h. We also use these defines in kernel/irq.c and express SIE/SIP flags in-terms of SCAUSE interrupt causes. Signed-off-by: Anup Patel --- arch/riscv/include/asm/csr.h | 25 + arch/riscv/