Re: [PATCH v3] checkpatch: add new warnings to author signoff checks.

2020-10-06 Thread Joe Perches
On Tue, 2020-10-06 at 18:45 +0530, Dwaipayan Ray wrote: > To summarize it, two changes that could be made are > the CHK for subaddress extension could be converted to > a WARN, and the WARN in case of a missing author signoff > could be converted to an ERROR. Sure, why not...

Re: [PATCH v3] checkpatch: add new warnings to author signoff checks.

2020-10-06 Thread Dwaipayan Ray
> > > Except for comments and quotes like: > > > > > > From: J. Random Developer (BigCorp) > > > Signed-off-by: "J. Random Developer" > > > > > > I think any time there's a mismatch, there > > > should be a warning emitted. > > > > > > That includes any subaddress detail differenc

Re: [PATCH v3] checkpatch: add new warnings to author signoff checks.

2020-10-05 Thread Lukas Bulwahn
On Tue, 6 Oct 2020, Dwaipayan Ray wrote: > On Tue, Oct 6, 2020 at 2:39 AM Joe Perches wrote: > > > > On Tue, 2020-10-06 at 01:37 +0530, Dwaipayan Ray wrote: > > > On Tue, Oct 6, 2020 at 1:07 AM Joe Perches wrote: > > > > On Tue, 2020-10-06 at 00:54 +0530, Dwaipayan Ray wrote: > > > > > The aut

Re: [PATCH v3] checkpatch: add new warnings to author signoff checks.

2020-10-05 Thread Dwaipayan Ray
On Tue, Oct 6, 2020 at 2:39 AM Joe Perches wrote: > > On Tue, 2020-10-06 at 01:37 +0530, Dwaipayan Ray wrote: > > On Tue, Oct 6, 2020 at 1:07 AM Joe Perches wrote: > > > On Tue, 2020-10-06 at 00:54 +0530, Dwaipayan Ray wrote: > > > > The author signed-off-by checks are currently very vague. > > >

Re: [PATCH v3] checkpatch: add new warnings to author signoff checks.

2020-10-05 Thread Joe Perches
On Tue, 2020-10-06 at 01:37 +0530, Dwaipayan Ray wrote: > On Tue, Oct 6, 2020 at 1:07 AM Joe Perches wrote: > > On Tue, 2020-10-06 at 00:54 +0530, Dwaipayan Ray wrote: > > > The author signed-off-by checks are currently very vague. > > > Cases like same name or same address are not handled separat

Re: [PATCH v3] checkpatch: add new warnings to author signoff checks.

2020-10-05 Thread Dwaipayan Ray
On Tue, Oct 6, 2020 at 1:07 AM Joe Perches wrote: > > On Tue, 2020-10-06 at 00:54 +0530, Dwaipayan Ray wrote: > > The author signed-off-by checks are currently very vague. > > Cases like same name or same address are not handled separately. > > When you run tests for this, how many mismatches are

Re: [PATCH v3] checkpatch: add new warnings to author signoff checks.

2020-10-05 Thread Joe Perches
On Tue, 2020-10-06 at 00:54 +0530, Dwaipayan Ray wrote: > The author signed-off-by checks are currently very vague. > Cases like same name or same address are not handled separately. When you run tests for this, how many mismatches are caused by name formatting changes like: From: "Developer, J.

[PATCH v3] checkpatch: add new warnings to author signoff checks.

2020-10-05 Thread Dwaipayan Ray
The author signed-off-by checks are currently very vague. Cases like same name or same address are not handled separately. For example, running checkpatch on commit be6577af0cef ("parisc: Add atomic64_set_release() define to avoid CPU soft lockups"), gives: WARNING: Missing Signed-off-by: line by