> > > Except for comments and quotes like: > > > > > > From: J. Random Developer (BigCorp) <j...@bigcorp.com> > > > Signed-off-by: "J. Random Developer" <j...@bigcorp.com> > > > > > > I think any time there's a mismatch, there > > > should be a warning emitted. > > > > > > That includes any subaddress detail difference. > > > > > > > > Hi, > > Yeah these cases are being handled. > > > > Comments and quotes don't generate any warning message but > > all the other mismatches do. > > > > Only the check for subaddress generates a --strict check message. > > others are all WARN messages. It was followed from our discussion at > > https://lore.kernel.org/linux-kernel-mentees/7b52e085f0b69ad1742966f8eacd02deb9299b96.ca...@perches.com/ > > > > So does it need to be changed to a WARN or is it fine like that? > > > > I will repeat what I suggested before: > > I think the complete mismatch where we cannot even find a name or an email > match the author deserves to be reported as ERROR. > > Dwaipayan, if Joe does not disagree, could you change that in your PATCH v4? >
Yes sure I hope to do that after Joe gives his affirmation. To summarize it, two changes that could be made are the CHK for subaddress extension could be converted to a WARN, and the WARN in case of a missing author signoff could be converted to an ERROR. Thanks, Dwaipayan.
