Hi Marcel,
On Wed, Nov 26, 2014, Marcel Holtmann wrote:
> I think Marcel was after just providing a clarifying code comment in
> both places - having two branches of an if-statement doing exactly the
> same thing looks a bit weird to me. To make thins completely clear I'd
> sug
Hi Steven,
I think Marcel was after just providing a clarifying code comment in
both places - having two branches of an if-statement doing exactly the
same thing looks a bit weird to me. To make thins completely clear I'd
suggest adding a simple helper function that you can cal
On Thu, Nov 20, 2014 at 10:51 AM, Steven Walter wrote:
>> > I think Marcel was after just providing a clarifying code comment in
>> > both places - having two branches of an if-statement doing exactly the
>> > same thing looks a bit weird to me. To make thins completely clear I'd
>> > suggest addi
Hi Marcel,
On Thu, Nov 20, 2014, Marcel Holtmann wrote:
> > static u16 get_acl_flags(struct hci_conn *hcon, struct l2cap_chan *chan)
> > {
>
> If we do it with a helper functions, then it should only provide the
> l2cap_chan since we can get the hci_conn from there.
One of the places it'd get ca
Hi Johan,
>> The bluetooth spec states that automatically flushable packets may not
>> be sent over a LE-U link.
>>
>> Signed-off-by: Steven Walter
>> ---
>> net/bluetooth/l2cap_core.c | 14 --
>> 1 file changed, 8 insertions(+), 6 deletions(-)
>>
>> diff --git a/net/bluetooth/l2cap_
Hi Steven,
On Wed, Nov 19, 2014, Steven Walter wrote:
> The bluetooth spec states that automatically flushable packets may not
> be sent over a LE-U link.
>
> Signed-off-by: Steven Walter
> ---
> net/bluetooth/l2cap_core.c | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
The bluetooth spec states that automatically flushable packets may not
be sent over a LE-U link.
Signed-off-by: Steven Walter
---
net/bluetooth/l2cap_core.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
7 matches
Mail list logo
