Re: [PATCH v2 4/4] MIPS: memset.S: Add comments to fault fixup handlers

2018-05-22 Thread Matt Redfearn
Hi James, On 21/05/18 17:14, James Hogan wrote: On Tue, Apr 17, 2018 at 04:40:03PM +0100, Matt Redfearn wrote: diff --git a/arch/mips/lib/memset.S b/arch/mips/lib/memset.S index 1cc306520a55..a06dabe99d4b 100644 --- a/arch/mips/lib/memset.S +++ b/arch/mips/lib/memset.S @@ -231,16 +231,25 @@

Re: [PATCH v2 4/4] MIPS: memset.S: Add comments to fault fixup handlers

2018-05-21 Thread James Hogan
On Tue, Apr 17, 2018 at 04:40:03PM +0100, Matt Redfearn wrote: > diff --git a/arch/mips/lib/memset.S b/arch/mips/lib/memset.S > index 1cc306520a55..a06dabe99d4b 100644 > --- a/arch/mips/lib/memset.S > +++ b/arch/mips/lib/memset.S > @@ -231,16 +231,25 @@ > > #ifdef CONFIG_CPU_MIPSR6 > .Lbyte_fix

[PATCH v2 4/4] MIPS: memset.S: Add comments to fault fixup handlers

2018-04-17 Thread Matt Redfearn
It is not immediately obvious what the expected inputs to these fault handlers is and how they calculate the number of unset bytes. Having stared deeply at this in order to fix some corner cases, add some comments to addist those who follow. Signed-off-by: Matt Redfearn --- Changes in v2: - Add