RE: [PATCH v2 3/4] net: make tcp_cleanup_rbuf private

2014-01-10 Thread David Laight
From: David Miller ... > > On Thu, Jan 9, 2014 at 12:26 PM, Neal Cardwell wrote: > >> On Thu, Jan 9, 2014 at 3:16 PM, Dan Williams > >> wrote: > >>> net_dma was the only external user so this can become local to tcp.c > >>> again. > >> ... > >>> -void tcp_cleanup_rbuf(struct sock *sk, int copied

Re: [PATCH v2 3/4] net: make tcp_cleanup_rbuf private

2014-01-09 Thread David Miller
From: Dan Williams Date: Thu, 9 Jan 2014 12:33:29 -0800 > On Thu, Jan 9, 2014 at 12:26 PM, Neal Cardwell wrote: >> On Thu, Jan 9, 2014 at 3:16 PM, Dan Williams >> wrote: >>> net_dma was the only external user so this can become local to tcp.c >>> again. >> ... >>> -void tcp_cleanup_rbuf(struct

Re: [PATCH v2 3/4] net: make tcp_cleanup_rbuf private

2014-01-09 Thread Dan Williams
On Thu, Jan 9, 2014 at 12:26 PM, Neal Cardwell wrote: > On Thu, Jan 9, 2014 at 3:16 PM, Dan Williams wrote: >> net_dma was the only external user so this can become local to tcp.c >> again. > ... >> -void tcp_cleanup_rbuf(struct sock *sk, int copied) >> +static void cleanup_rbuf(struct sock *sk,

Re: [PATCH v2 3/4] net: make tcp_cleanup_rbuf private

2014-01-09 Thread Neal Cardwell
On Thu, Jan 9, 2014 at 3:16 PM, Dan Williams wrote: > net_dma was the only external user so this can become local to tcp.c > again. ... > -void tcp_cleanup_rbuf(struct sock *sk, int copied) > +static void cleanup_rbuf(struct sock *sk, int copied) I would vote to keep the tcp_ prefix. In the TCP c

[PATCH v2 3/4] net: make tcp_cleanup_rbuf private

2014-01-09 Thread Dan Williams
net_dma was the only external user so this can become local to tcp.c again. Cc: James Morris Cc: Patrick McHardy Cc: David S. Miller Cc: Alexey Kuznetsov Cc: Hideaki YOSHIFUJI Signed-off-by: Dan Williams --- New in v2 include/net/tcp.h |1 - net/ipv4/tcp.c| 10 +- 2 files