On Thu, Jan 9, 2014 at 12:26 PM, Neal Cardwell <ncardw...@google.com> wrote: > On Thu, Jan 9, 2014 at 3:16 PM, Dan Williams <dan.j.willi...@intel.com> wrote: >> net_dma was the only external user so this can become local to tcp.c >> again. > ... >> -void tcp_cleanup_rbuf(struct sock *sk, int copied) >> +static void cleanup_rbuf(struct sock *sk, int copied) > > I would vote to keep the tcp_ prefix. In the TCP code base that is the > more common idiom, even for internal/static TCP functions, and > personally I find it easier to read and work with in stack traces, > etc. My 2 cents. >
Ok. It was cleanup_rbuf() in a former life, but one vote for leaving the name as is is enough for me. -- Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
