Re: [PATCH v2 1/9] hwmon: Introduce hwmon_device_register_with_groups

2013-09-01 Thread Greg Kroah-Hartman
On Sun, Sep 01, 2013 at 10:55:34AM -0700, Guenter Roeck wrote: > On 09/01/2013 09:24 AM, Greg Kroah-Hartman wrote: > >This looks good, just one minor question about the > >non-driver-core-related code: > > > >>+struct device * > >>+hwmon_device_register_with_groups(struct device *dev, const char *n

Re: [PATCH v2 1/9] hwmon: Introduce hwmon_device_register_with_groups

2013-09-01 Thread Guenter Roeck
On 09/01/2013 09:24 AM, Greg Kroah-Hartman wrote: This looks good, just one minor question about the non-driver-core-related code: +struct device * +hwmon_device_register_with_groups(struct device *dev, const char *name, + void *drvdata, +

Re: [PATCH v2 1/9] hwmon: Introduce hwmon_device_register_with_groups

2013-09-01 Thread Greg Kroah-Hartman
This looks good, just one minor question about the non-driver-core-related code: > +struct device * > +hwmon_device_register_with_groups(struct device *dev, const char *name, > + void *drvdata, > + const struct attribute_group **groups) >

[PATCH v2 1/9] hwmon: Introduce hwmon_device_register_with_groups

2013-08-31 Thread Guenter Roeck
hwmon_device_register_with_groups() lets callers register a hwmon device together with all sysfs attributes in a single call. When using hwmon_device_register_with_groups(), hwmon attributes are attached to the hwmon device directly and no longer with its parent device. Signed-off-by: Guenter Roe