This looks good, just one minor question about the
non-driver-core-related code:
> +struct device *
> +hwmon_device_register_with_groups(struct device *dev, const char *name,
> + void *drvdata,
> + const struct attribute_group **groups)
> {
> - struct device *hwdev;
> - int id;
> + struct hwmon_device *hwdev;
> + int err, id;
>
> id = ida_simple_get(&hwmon_ida, 0, 0, GFP_KERNEL);
> if (id < 0)
> return ERR_PTR(id);
Don't you need a lock around the ida_simple_get call to ensure hwmon_ida
is not being used at the same time twice? Or does the ida framework
handle that ok?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
