Re: [PATCH v2 05/13] uprobes: add arch write opcode hook

2013-11-02 Thread Oleg Nesterov
On 11/01, David Long wrote: > > On 10/29/13 15:59, Oleg Nesterov wrote: >> >> Or. arm can actually reimplement set_swbp(). This doesn't mean the >> duplication of write_opcode() code, we can simply export this helper. >> > > That actually looks to me like the cleanest approach. I have changed > th

Re: [PATCH v2 05/13] uprobes: add arch write opcode hook

2013-11-01 Thread David Long
On 10/29/13 15:59, Oleg Nesterov wrote: On 10/28, Oleg Nesterov wrote: Yes, yes, sorry for confusion. What I actually tried to suggest is something like the trivial patch below. Then arm can do: uprobe_opcode_t arch_uprobe_swbp_insn(struct arch_uprobe *auprobe) {

Re: [PATCH v2 05/13] uprobes: add arch write opcode hook

2013-10-29 Thread Oleg Nesterov
On 10/28, Oleg Nesterov wrote: > > Yes, yes, sorry for confusion. What I actually tried to suggest is > something like the trivial patch below. > > Then arm can do: > > uprobe_opcode_t arch_uprobe_swbp_insn(struct arch_uprobe *auprobe) > { > return __opcode_to_mem_arm(aupr

Re: [PATCH v2 05/13] uprobes: add arch write opcode hook

2013-10-28 Thread Oleg Nesterov
On 10/23, David Long wrote: > > On 10/19/13 12:50, Oleg Nesterov wrote: >> On 10/15, David Long wrote: >>> >>> Allow arches to write the opcode with a custom function. ARM needs to >>> customize the swbp instruction depending on the condition code of the >>> instruction it replaces. >> >> Well, we

Re: [PATCH v2 05/13] uprobes: add arch write opcode hook

2013-10-23 Thread David Long
On 10/19/13 12:50, Oleg Nesterov wrote: On 10/15, David Long wrote: Allow arches to write the opcode with a custom function. ARM needs to customize the swbp instruction depending on the condition code of the instruction it replaces. Well, we already have "__weak set_swbp(auprobe, ...)", can'

Re: [PATCH v2 05/13] uprobes: add arch write opcode hook

2013-10-19 Thread Oleg Nesterov
On 10/15, David Long wrote: > > Allow arches to write the opcode with a custom function. ARM needs to > customize the swbp instruction depending on the condition code of the > instruction it replaces. Well, we already have "__weak set_swbp(auprobe, ...)", can't arm use it? If not, > +void __wea

[PATCH v2 05/13] uprobes: add arch write opcode hook

2013-10-15 Thread David Long
From: Rabin Vincent Allow arches to write the opcode with a custom function. ARM needs to customize the swbp instruction depending on the condition code of the instruction it replaces. Signed-off-by: Rabin Vincent Signed-off-by: David A. Long --- include/linux/uprobes.h | 3 +++ kernel/even