On 10/15, David Long wrote:
>
> Allow arches to write the opcode with a custom function. ARM needs to
> customize the swbp instruction depending on the condition code of the
> instruction it replaces.
Well, we already have "__weak set_swbp(auprobe, ...)", can't arm use it?
If not,
> +void __weak arch_uprobe_write_opcode(struct arch_uprobe *auprobe, void
> *vaddr,
> + uprobe_opcode_t opcode)
> +{
> + memcpy(vaddr, &opcode, UPROBE_SWBP_INSN_SIZE);
> +}
> ...
> - copy_to_page(new_page, vaddr, &opcode, UPROBE_SWBP_INSN_SIZE);
> + vaddr_new = kmap_atomic(new_page);
> + arch_uprobe_write_opcode(auprobe, vaddr_new + (vaddr & ~PAGE_MASK),
> + opcode);
> + kunmap_atomic(vaddr_new);
Again, if you need to add the new __weak helper, I think it should simply
do copy_to_page().
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
