Re: [PATCH v2] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h

2014-01-22 Thread David Cohen
On Wed, Jan 22, 2014 at 05:10:47PM -0500, Paul Gortmaker wrote: > On 14-01-22 05:03 PM, H. Peter Anvin wrote: > > On 01/22/2014 01:50 PM, David Cohen wrote: > >>> > >>> -void * __cpuinit get_penwell_ops() > >>> +void *get_penwell_ops() > >>> { > >>> return &penwell_ops; > >>> } > >>> > >>>

Re: [PATCH v2] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h

2014-01-22 Thread Paul Gortmaker
On 14-01-22 05:03 PM, H. Peter Anvin wrote: > On 01/22/2014 01:50 PM, David Cohen wrote: >>> >>> -void * __cpuinit get_penwell_ops() >>> +void *get_penwell_ops() >>> { >>> return &penwell_ops; >>> } >>> >>> -void * __cpuinit get_cloverview_ops() >>> +void *get_cloverview_ops() >>> { >>>

Re: [PATCH v2] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h

2014-01-22 Thread David Cohen
On Wed, Jan 22, 2014 at 04:58:28PM -0500, Paul Gortmaker wrote: > On 14-01-22 04:50 PM, David Cohen wrote: > > On Wed, Jan 22, 2014 at 12:34:15PM -0500, Paul Gortmaker wrote: > >> Commit 85611e3febe78955a519f5f9eb47b941525c8c76 ("x86, intel-mid: > >> Add Clovertrail platform support") added new ins

Re: [PATCH v2] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h

2014-01-22 Thread H. Peter Anvin
On 01/22/2014 01:50 PM, David Cohen wrote: >> >> -void * __cpuinit get_penwell_ops() >> +void *get_penwell_ops() >> { >> return &penwell_ops; >> } >> >> -void * __cpuinit get_cloverview_ops() >> +void *get_cloverview_ops() >> { >> return &penwell_ops; >> } > Can someone also fin

Re: [PATCH v2] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h

2014-01-22 Thread Paul Gortmaker
On 14-01-22 04:50 PM, David Cohen wrote: > On Wed, Jan 22, 2014 at 12:34:15PM -0500, Paul Gortmaker wrote: >> Commit 85611e3febe78955a519f5f9eb47b941525c8c76 ("x86, intel-mid: >> Add Clovertrail platform support") added new instances of __cpuinit >> usage. We removed this a couple versions ago; we

Re: [PATCH v2] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h

2014-01-22 Thread David Cohen
On Wed, Jan 22, 2014 at 12:34:15PM -0500, Paul Gortmaker wrote: > Commit 85611e3febe78955a519f5f9eb47b941525c8c76 ("x86, intel-mid: > Add Clovertrail platform support") added new instances of __cpuinit > usage. We removed this a couple versions ago; we now want to remove > the compat no-op stubs.

Re: [PATCH v2] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h

2014-01-22 Thread David Cohen
On Wed, Jan 22, 2014 at 12:34:15PM -0500, Paul Gortmaker wrote: > Commit 85611e3febe78955a519f5f9eb47b941525c8c76 ("x86, intel-mid: > Add Clovertrail platform support") added new instances of __cpuinit > usage. We removed this a couple versions ago; we now want to remove > the compat no-op stubs.

[PATCH v2] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h

2014-01-22 Thread Paul Gortmaker
Commit 85611e3febe78955a519f5f9eb47b941525c8c76 ("x86, intel-mid: Add Clovertrail platform support") added new instances of __cpuinit usage. We removed this a couple versions ago; we now want to remove the compat no-op stubs. Introducing new users is not what we want to see at this point in time,