Re: [PATCH v2] perf tools: Remove cast of non-variadic function to variadic

2013-11-01 Thread Michael Hudson-Doyle
Arnaldo Carvalho de Melo writes: > Em Thu, Oct 31, 2013 at 04:47:45PM -0700, Michael Hudson-Doyle escreveu: >> -int percent_color_snprintf(char *bf, size_t size, const char *fmt, double >> percent) >> +int percent_color_snprintf(char *bf, size_t size, const char *fmt, ...) >> { >> -const ch

Re: [PATCH v2] perf tools: Remove cast of non-variadic function to variadic

2013-11-01 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 31, 2013 at 04:47:45PM -0700, Michael Hudson-Doyle escreveu: > -int percent_color_snprintf(char *bf, size_t size, const char *fmt, double > percent) > +int percent_color_snprintf(char *bf, size_t size, const char *fmt, ...) > { > - const char *color = get_percent_color(percent); >

[PATCH v2] perf tools: Remove cast of non-variadic function to variadic

2013-10-31 Thread Michael Hudson-Doyle
4fb71074a570 (perf ui/hist: Consolidate hpp helpers) introduced a cast of percent_color_snprintf to a function pointer type with varargs. Change percent_color_snprintf to be variadic and remove the cast. The symptom of this was all percentages being reported as 0.00% in perf report --stdio output