Re: [PATCH v2] dma-debug: enhance dma_debug_device_change() to check for mapping errors

2014-01-10 Thread Shuah Khan
On 01/07/2014 10:22 AM, Shuah Khan wrote: On 01/07/2014 08:12 AM, Joerg Roedel wrote: On Tue, Jan 07, 2014 at 08:00:33AM -0700, Shuah Khan wrote: This patch and a follow-on cocinelli warning fix patch are in linux-next. Would you like me to send a patch relative to the change in linux-next or c

Re: [PATCH v2] dma-debug: enhance dma_debug_device_change() to check for mapping errors

2014-01-07 Thread Shuah Khan
On 01/07/2014 08:12 AM, Joerg Roedel wrote: On Tue, Jan 07, 2014 at 08:00:33AM -0700, Shuah Khan wrote: This patch and a follow-on cocinelli warning fix patch are in linux-next. Would you like me to send a patch relative to the change in linux-next or cut a new patch against the latest Linus's g

Re: [PATCH v2] dma-debug: enhance dma_debug_device_change() to check for mapping errors

2014-01-07 Thread Joerg Roedel
On Tue, Jan 07, 2014 at 08:00:33AM -0700, Shuah Khan wrote: > This patch and a follow-on cocinelli warning fix patch are in > linux-next. Would you like me to send a patch relative to the change > in linux-next or cut a new patch against the latest Linus's git. I > can go either way. We just have t

Re: [PATCH v2] dma-debug: enhance dma_debug_device_change() to check for mapping errors

2014-01-07 Thread Shuah Khan
On 01/07/2014 07:26 AM, Joerg Roedel wrote: On Fri, Jan 03, 2014 at 11:26:04AM -0700, Shuah Khan wrote: On 12/30/2013 07:15 AM, Joerg Roedel wrote: I think it is better to check for this in a seperate function and use err_printk instead of dev_warn in the end to print the errors. The new functi

Re: [PATCH v2] dma-debug: enhance dma_debug_device_change() to check for mapping errors

2014-01-07 Thread Joerg Roedel
On Fri, Jan 03, 2014 at 11:26:04AM -0700, Shuah Khan wrote: > On 12/30/2013 07:15 AM, Joerg Roedel wrote: > >I think it is better to check for this in a seperate function and use > >err_printk instead of dev_warn in the end to print the errors. > >The new function can then be called in the dma_debu

Re: [PATCH v2] dma-debug: enhance dma_debug_device_change() to check for mapping errors

2014-01-03 Thread Shuah Khan
On 12/30/2013 07:15 AM, Joerg Roedel wrote: On Wed, Nov 13, 2013 at 01:56:08PM -0700, Shuah Khan wrote: dma-debug checks to verify if driver validated the address returned by dma mapping routines when driver does unmap. If a driver doesn't call unmap, failure to check mapping errors isn't detect

Re: [PATCH v2] dma-debug: enhance dma_debug_device_change() to check for mapping errors

2013-12-30 Thread Joerg Roedel
On Wed, Nov 13, 2013 at 01:56:08PM -0700, Shuah Khan wrote: > dma-debug checks to verify if driver validated the address returned by > dma mapping routines when driver does unmap. If a driver doesn't call > unmap, failure to check mapping errors isn't detected and reported. > > Enhancing existing

[PATCH v2] dma-debug: enhance dma_debug_device_change() to check for mapping errors

2013-11-13 Thread Shuah Khan
dma-debug checks to verify if driver validated the address returned by dma mapping routines when driver does unmap. If a driver doesn't call unmap, failure to check mapping errors isn't detected and reported. Enhancing existing bus notifier_call dma_debug_device_change() to check for mapping error