Re: [PATCH v2] Moved module init-functions into the module.

2017-06-22 Thread Steve Kemp
> > The module initialization code belongs in the module. > > The LSM infrastructure should have an absolute minimum > > of module specific information. I would rather see the > > "minor" modules (yama, loadpin) changed to use the module > > registration scheme used by the "major" modules, but that

Re: [PATCH v2] Moved module init-functions into the module.

2017-06-22 Thread Kees Cook
On Thu, Jun 22, 2017 at 9:54 AM, Casey Schaufler wrote: > On 6/22/2017 1:45 AM, Steve Kemp wrote: >> This commit moves the call to initialize the LSM modules inline >> into the LSM-files themselves. >> >> This removes the need to hunt around for the setup, which was >> something that bit me when I

Re: [PATCH v2] Moved module init-functions into the module.

2017-06-22 Thread Casey Schaufler
On 6/22/2017 1:45 AM, Steve Kemp wrote: > This commit moves the call to initialize the LSM modules inline > into the LSM-files themselves. > > This removes the need to hunt around for the setup, which was > something that bit me when I wrote my own (unrelated) LSM. > > Keeping LSM code in one place

[PATCH v2] Moved module init-functions into the module.

2017-06-22 Thread Steve Kemp
This commit moves the call to initialize the LSM modules inline into the LSM-files themselves. This removes the need to hunt around for the setup, which was something that bit me when I wrote my own (unrelated) LSM. Keeping LSM code in one place, including the setup of the hooks seems like a sane