[PATCH net-next v2 4/4] selftests: drv-net: Test that NAPI ID is non-zero

2025-04-18 Thread Joe Damato
Test that the SO_INCOMING_NAPI_ID of a network file descriptor is non-zero. This ensures that either the core networking stack or, in some cases like netdevsim, the driver correctly sets the NAPI ID. Signed-off-by: Joe Damato --- .../testing/selftests/drivers/net/.gitignore | 1 + tools/testin

Re: [PATCH net-next v2 4/4] selftests: drv-net: Test that NAPI ID is non-zero

2025-04-18 Thread Jakub Kicinski
On Thu, 17 Apr 2025 01:32:42 + Joe Damato wrote: > Test that the SO_INCOMING_NAPI_ID of a network file descriptor is > non-zero. This ensures that either the core networking stack or, in some > cases like netdevsim, the driver correctly sets the NAPI ID. > > Signed-off-by: Joe Damato > --- >

Re: [PATCH net-next v2 4/4] selftests: drv-net: Test that NAPI ID is non-zero

2025-04-17 Thread Joe Damato
On Thu, Apr 17, 2025 at 09:53:10AM -0700, Jakub Kicinski wrote: > On Thu, 17 Apr 2025 09:43:23 -0700 Joe Damato wrote: > > I think the main outstanding thing is Paolo's feedback which maybe > > (?) is due to a Python version difference? If you have any guidance > > on how to proceed on that, I'd ap

Re: [PATCH net-next v2 4/4] selftests: drv-net: Test that NAPI ID is non-zero

2025-04-17 Thread Jakub Kicinski
On Thu, 17 Apr 2025 09:43:23 -0700 Joe Damato wrote: > I think the main outstanding thing is Paolo's feedback which maybe > (?) is due to a Python version difference? If you have any guidance > on how to proceed on that, I'd appreciate it [1]. yes, it's a Python version, I made the same mistake in

Re: [PATCH net-next v2 4/4] selftests: drv-net: Test that NAPI ID is non-zero

2025-04-17 Thread Joe Damato
On Thu, Apr 17, 2025 at 06:46:15AM -0700, Jakub Kicinski wrote: > On Thu, 17 Apr 2025 01:32:42 + Joe Damato wrote: > > Test that the SO_INCOMING_NAPI_ID of a network file descriptor is > > non-zero. This ensures that either the core networking stack or, in some > > cases like netdevsim, the dri

Re: [PATCH net-next v2 4/4] selftests: drv-net: Test that NAPI ID is non-zero

2025-04-17 Thread Joe Damato
On Thu, Apr 17, 2025 at 09:26:22AM +0200, Paolo Abeni wrote: > On 4/17/25 3:32 AM, Joe Damato wrote: > > diff --git a/tools/testing/selftests/drivers/net/napi_id.py > > b/tools/testing/selftests/drivers/net/napi_id.py > > new file mode 100755 > > index ..aee6f90be49b > > --- /dev/null

Re: [PATCH net-next v2 4/4] selftests: drv-net: Test that NAPI ID is non-zero

2025-04-17 Thread Xiao Liang
On Thu, Apr 17, 2025 at 9:33 AM Joe Damato wrote: > [...] > diff --git a/tools/testing/selftests/drivers/net/napi_id.py > b/tools/testing/selftests/drivers/net/napi_id.py > new file mode 100755 > index ..aee6f90be49b > --- /dev/null > +++ b/tools/testing/selftests/drivers/net/napi_id.

Re: [PATCH net-next v2 4/4] selftests: drv-net: Test that NAPI ID is non-zero

2025-04-17 Thread Paolo Abeni
On 4/17/25 3:32 AM, Joe Damato wrote: > diff --git a/tools/testing/selftests/drivers/net/napi_id.py > b/tools/testing/selftests/drivers/net/napi_id.py > new file mode 100755 > index ..aee6f90be49b > --- /dev/null > +++ b/tools/testing/selftests/drivers/net/napi_id.py > @@ -0,0 +1,24 @@