On Thu, Apr 17, 2025 at 09:53:10AM -0700, Jakub Kicinski wrote:
> On Thu, 17 Apr 2025 09:43:23 -0700 Joe Damato wrote:
> > I think the main outstanding thing is Paolo's feedback which maybe
> > (?) is due to a Python version difference? If you have any guidance
> > on how to proceed on that, I'd appreciate it [1].
>
> yes, it's a Python version, I made the same mistake in the past.
> Older Pythons terminate an fstring too early.
> Just switch from ' to " inside the fstring, like you would in bash
> if you wanted to quote a quote character. The two are functionally
> equivalent.
OK thanks for the details. Sorry that I am learning Python via
netdev ;)
I did this so it matches the style of the other fstring a few lines
below:
- listen_cmd = f'{bin_remote} {cfg.addr_v['4']} {port}'
+ listen_cmd = f"{bin_remote} {cfg.addr_v['4']} {port}"
Test works and passes for me on my system, so I'll send the v3
tonight when I've hit 24 hrs.
Thanks!
