Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE

2021-03-20 Thread Leon Romanovsky
On Thu, Mar 18, 2021 at 10:55:51AM -0700, Linus Torvalds wrote: > On Thu, Mar 18, 2021 at 10:49 AM Leon Romanovsky wrote: > > > > No, I opened patch and added the note manually, so it is definitely my VIM. > > Most likely this part of my .vimrc caused it. > > Ok, that would do it. > > Yeah, whit

Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE

2021-03-18 Thread Linus Torvalds
On Thu, Mar 18, 2021 at 10:49 AM Leon Romanovsky wrote: > > No, I opened patch and added the note manually, so it is definitely my VIM. > Most likely this part of my .vimrc caused it. Ok, that would do it. Yeah, whitespace is easy to "fix" at patch application time, but it really is meaningful a

Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE

2021-03-18 Thread Leon Romanovsky
On Thu, Mar 18, 2021 at 10:36:36AM -0700, Linus Torvalds wrote: > On Thu, Mar 18, 2021 at 12:55 AM Leon Romanovsky wrote: > > > > > > Also, your email seems to have swallowed spaces at the ends of lines. > > > > > > I can (and did) apply the patch with "--whitespace=fix", but that then > > > cause

Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE

2021-03-18 Thread Linus Torvalds
On Thu, Mar 18, 2021 at 12:55 AM Leon Romanovsky wrote: > > > > Also, your email seems to have swallowed spaces at the ends of lines. > > > > I can (and did) apply the patch with "--whitespace=fix", but that then > > causes git to fix some _other_ whitespace too, so the end result isn't > > quite

Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE

2021-03-18 Thread Leon Romanovsky
On Wed, Mar 17, 2021 at 01:17:32PM -0700, Linus Torvalds wrote: > On Wed, Mar 17, 2021 at 3:46 AM Leon Romanovsky wrote: > > > > I'm sending this patch to you directly because it is much saner to > > apply it in one place instead of multiple patches saga that will > > span for at least two cycles

Re: [PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE

2021-03-17 Thread Linus Torvalds
On Wed, Mar 17, 2021 at 3:46 AM Leon Romanovsky wrote: > > I'm sending this patch to you directly because it is much saner to > apply it in one place instead of multiple patches saga that will > span for at least two cycles if per-maintainer path will be taken. > > It applies cleanly on v5.12-rc2

[PATCH master] module: remove never implemented MODULE_SUPPORTED_DEVICE

2021-03-17 Thread Leon Romanovsky
From: Leon Romanovsky MODULE_SUPPORTED_DEVICE was added in pre-git era and never was implemented. We can safely remove it, because the kernel has grown to have many more reliable mechanisms to determine if device is supported or not. Signed-off-by: Leon Romanovsky --- Hi Linus, I'm sending thi