On Thu, Mar 18, 2021 at 10:36:36AM -0700, Linus Torvalds wrote: > On Thu, Mar 18, 2021 at 12:55 AM Leon Romanovsky <l...@kernel.org> wrote: > > > > > > Also, your email seems to have swallowed spaces at the ends of lines. > > > > > > I can (and did) apply the patch with "--whitespace=fix", but that then > > > causes git to fix some _other_ whitespace too, so the end result isn't > > > quite the same. Oh well. > > > > > > Please check what's up with your email sending client that it seems to > > > remove space at end of lines in patches. > > > > This is strange, I'm sending patches with "git send-email" with pretty > > standard settings: > > Hmm. I can't tell whats' wrong, but both my own mailbox and the > lore.kernel.org clearly has missing whitespace at end of lines. > > You can see it yourself with a simple > > b4 am 20210317104547.442203-1-l...@kernel.org > > (assuming you have b4 installed, of course: > > https://pypi.org/project/b4/ > > but with a kernel.org address I'm sure you've seen the emails about it > even if you may not be a user).
Thanks, I'll try. > > > Also, I'm using mail.kernel.org as a SMTP especially to make sure that > > my mails are not mangled by our exchange server. > > Yeah, the email looks fine in any other way technically, it passes SPF > and DKIM, and I don't see anything else strange going on either. > > I think the same VIM issue that caused some whitespace line changes > for you in the patch might have then bitten you when you sent it out - > I know you must have edited the message, becasuse you have that > > "I'm sending this patch to you directly because it is much saner to > apply it in one place instead of multiple patches saga that will [...]" > > below the commit message, that you presumable added with "--annotate". No, I opened patch and added the note manually, so it is definitely my VIM. Most likely this part of my .vimrc caused it. " Remove trailing white spaces " http://vim.wikia.com/wiki/Remove_unwanted_spaces autocmd BufWritePre * %s/\s\+$//e > > > Are you sure that such change came from me and not from "--whitespace=fix"? > > Yup. See above on how you can just use b4 to download a copy yourself.. I'll try, thanks for taking the patch and for the analysis. > > Linus
